Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TableBase subclasses to render in template tag #377

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Allow TableBase subclasses to render in template tag #377

merged 1 commit into from
Sep 6, 2016

Conversation

shawnnapora
Copy link
Contributor

When I subclassed TableBase to extend it and constructed it with DeclarativeColumnsMetaclass, it failed to render in the templatetag render function because it was not a tables.Table. This patch would allow a subclass of TableBase to pass the isinstance check and render properly, and still allow tables.Table instances to pass the check.

@jieter
Copy link
Owner

jieter commented Sep 6, 2016

Makes sense, merging, thanks @shawnnapora!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants