Render template columns in pinned rows.

[khirstinova]

No description provided.

[jieter]

Py34-master is Django master which does not support python 3.4 anymore since it's the development version of django 2.1.

I'll update the config to reflect that tonight

[jieter]

Just pushed the updated tox config and triggered a rebuild.

[jieter]

Looking at your implementation: this fixed the problem for TemplateColumn, but what if I use a LinkColumn?
I don't really understand why BoundPinnedRow implements a custom _get_and_render_with method anyway...

[khirstinova]

I don't understand why there is a custom method here either. Because I didn't, I only fixed it for a template column. I see no reason why the overridden implementation exists, so this is why I asked the question when I opened the issue.

…

-K

________________________________ From: Jan Pieter Waagmeester <notifications@github.com> Sent: Thursday, October 5, 2017 3:04:22 PM To: bradleyayers/django-tables2 Cc: Kevin Hirst; Author Subject: Re: [bradleyayers/django-tables2] Render template columns in pinned rows. (#483) Looking at your implementation: this fixed the problem for TemplateColumn, but what if I use a LinkColumn? I don't really understand why BoundPinnedRow implements a custom _get_and_render_with method anyway... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#483 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYZ53cOO3zbUPgfZ9pngte9_3oOas6foks5spSg2gaJpZM4PvYOk>.

[jieter]

Your test also passes if I remove the custom method in BoundPinnedRows

[khirstinova]

I'm fine with that approach - I don't see anything wrong with it, was just trying to preserve a concern that apparently didn't exist. Would you like me to remove that and check it in?

[jieter]

@djk2 Any thoughts on removing BoundPinnedRow._get_and_render_with()?

[djk2]

I can't remember why I implemented custom method.
Looks that removing _get_and_render_with not break anything.
I think that is a good idea to remove this custom method.

[jieter]

@khirstinova do you want to add a commit removing the method?

[jieter]

@khirstinova Just merged, will remove the method in a minute.

Thanks for the pull!

[khirstinova]

Ok, thanks, I was traveling Friday, so thanks for taking care of this.

…

-K

________________________________ From: Jan Pieter Waagmeester <notifications@github.com> Sent: Saturday, October 7, 2017 4:19:05 AM To: bradleyayers/django-tables2 Cc: Kevin Hirst; Mention Subject: Re: [bradleyayers/django-tables2] Render template columns in pinned rows. (#483) @khirstinova<https://github.com/khirstinova> Just merged, will remove the method in a minute — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#483 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYZ53S-tC-6b1GDeUvKIJfyfH7e_0odBks5spzP5gaJpZM4PvYOk>.

[jieter]

released 1.12.0