-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: add a SignerWithContext
interface for custom sign implementations
#117
Comments
I've created a PR fleshing out the idea if you're interested @bradleyfalzon. Feedback welcome! |
Another valuable use case for the context is when using telemetry. The current trace is generally carried on the request context, so including the context allows actions taken during signing to be included in the wider request trace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current sign interface has the single
Sign
method:When implementing an AWS KMS signer, the lack of the context means the remote operation doesn't participate in the main context, so it's unaware of request timeouts or server shutdown.
What about adding:
An existing
Signer
implementation can be supported through a simple wrapper function:Then a configuration item for
WithContextSigner
or similar. Thoughts?I am able to raise a PR for this, or some more acceptable variation.
The text was updated successfully, but these errors were encountered: