Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Missing click noise #30

Closed
roblav96 opened this issue Sep 1, 2016 · 11 comments
Closed

[Android] Missing click noise #30

roblav96 opened this issue Sep 1, 2016 · 11 comments

Comments

@roblav96
Copy link

roblav96 commented Sep 1, 2016

The only way I can get the click noise to work on android is if I add a setTimeout method before calling topmost().navigate:

export function gotoAddConvo(args: EventData) {
    setTimeout(function() {
        topmost().navigate('listpage/listpage')
    }, 100)
}

Any idea why? Just curious 👼

@bradmartin
Copy link
Collaborator

Not really sure what you're referring to. There is no noise by default on the fab that I'm aware of. I've tried several apps with fab (inbox, twitter) and there's no noise on the fab tap. So do you have a sample app on the play store so I can see it in action. Is it the haptic feedback that you might be referring to?

@roblav96
Copy link
Author

roblav96 commented Sep 1, 2016

Yes it's the haptic feedback click/pop noise. It's in every app I've ever used on my phone. It's a sound; not a vibrate.

@roblav96
Copy link
Author

roblav96 commented Sep 1, 2016

Here's a quick screencast video. Turn up your volume, it's kinda faint.

https://vid.me/Lyu9

@bradmartin
Copy link
Collaborator

I've never heard that LOL. I don't have any app with a fab that does that,
never knew. Well to answer your question, no clue about it cause I've never
heard it

On Thu, Sep 1, 2016, 1:07 AM Rob Laverty notifications@github.com wrote:

Here's a quick screencast video. Turn up your volume, it's kinda faint.

https://vid.me/Lyu9


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFulhE1T6w_-8b6DTqyVwylQihO3PzWcks5qlmu2gaJpZM4JyPts
.

@bradmartin
Copy link
Collaborator

In that video was it also providing feedback on all buttons? If so I'm thinking this is device specific or something. I have haptic feedback on some buttons on my droid turbo 2 but none of my apps do it that I know of. I'm going to play around today and see if there's something I'm missing in twitter, messenger, Shazam, and inbox. They all use fab and material buttons and I just can't recall any feedback on button taps on my phone

@sitefinitysteve
Copy link
Contributor

Hmm yeah i just tested on my S6 in Gmail and Twitter full volume, no haptic or sound.

Think it is a thing in android though... setSoundEffectsEnabled?

@roblav96
Copy link
Author

roblav96 commented Sep 1, 2016

@bradmartin @sitefinitysteve This is an accessibility feature in the android settings.

Other Sounds

It's the touch sounds one.

@bradmartin
Copy link
Collaborator

Ahh so yea device setting. If you want to make a PR to enable the sound via an optional parameter (since you mentioned timeout, don't want that the default).

@roblav96
Copy link
Author

roblav96 commented Sep 1, 2016

@bradmartin Sure I'll give it a shot.

@bradmartin
Copy link
Collaborator

Nothing changed and I tested today (after turning the setting to ON) and the sound is there. Same as Twitter and Inbox apps FAB button sound (and all other taps it seems).

@roblav96
Copy link
Author

Yes everything is working properly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants