Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for native android icons #3

Merged
merged 1 commit into from
Feb 12, 2016
Merged

add support for native android icons #3

merged 1 commit into from
Feb 12, 2016

Conversation

lazaromenezes
Copy link
Contributor

Brad Martin,

I did a small refactor for icon loading code. Use ImageSource class to load resource or file icons and added support for built-in android icons.

The XML syntax didn't change now. The plugin tries loading from file or resource first, if it has not success it tries loading from android resources.

Thanks,
Lazaro

bradmartin added a commit that referenced this pull request Feb 12, 2016
add support for native android icons
@bradmartin bradmartin merged commit f641555 into nstudio:master Feb 12, 2016
@bradmartin
Copy link
Collaborator

Updated on npm 👍

@lazaromenezes
Copy link
Contributor Author

:( I guess I broke something.....trying to fix it

@bradmartin
Copy link
Collaborator

If. the icon isn't working from path or resources. You might want to check
some code in the -videoplayer that checks path and resources. I've been
told that the utils for those checks aren't perfect

On Fri, Feb 12, 2016, 1:52 PM Lázaro Danillo Menezes <
notifications@github.com> wrote:

:( I guess I broke something.....trying to fix it


Reply to this email directly or view it on GitHub
#3 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants