Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update naming conventions #176

Open
mschrimpf opened this issue May 22, 2023 · 0 comments
Open

update naming conventions #176

mschrimpf opened this issue May 22, 2023 · 0 comments

Comments

@mschrimpf
Copy link
Member

BenchmarkType currently has a field visible which controls whether or not the benchmark is shown on the public leaderboard.

Since this naming is potentially confusing with visible or public/private code, let's rename this field to leaderboard_public. Later on, we can then use the naming code_public for the visibility of source code. This way, users can have e.g. benchmarks or models with code_public=False but still show them on the website leaderboard_public=True. Or vice versa, the code can be public code_public=True but the benchmark/model is not shown on the website for everyone leaderboard_public=False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant