Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that users are getting emails upon failed submissions #80

Closed
pellegreene opened this issue Feb 14, 2024 · 0 comments
Closed

Verify that users are getting emails upon failed submissions #80

pellegreene opened this issue Feb 14, 2024 · 0 comments
Assignees

Comments

@pellegreene
Copy link
Contributor

  1. Make sure email method actually works (core, each repo has a submissions dir, and an endpoints.py that handles communication between repos)
    https://github.com/brain-score/core/blob/ec8d7eb6ff3598e82b58917fa1708172f2c569ad/brainscore_core/submission/endpoints.py#L74C9-L74C24
    Travis could be failing, too. Check that to be safe
    https://github.com/brain-score/vision/blob/master/.travis.yml
    https://github.com/brain-score/core/blob/main/brainscore_core/travis/submission_failure.yml

  2. Right now the notification that you get via submission doesn’t tell you that this will create a PR that will be tested. Need to add that with a link to the PR to track the status.

Nice to have: Check to see if there is a PR for the given model ID and don’t double submit.

Add-on: Check through PRs and remove any existing duplicates. Can't have a cluttered development environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants