Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit Card auto fill only fills first 4 digits with Roboform #356

Closed
kilvroch opened this issue Mar 13, 2018 · 5 comments
Closed

Credit Card auto fill only fills first 4 digits with Roboform #356

kilvroch opened this issue Mar 13, 2018 · 5 comments

Comments

@kilvroch
Copy link

kilvroch commented Mar 13, 2018

General information

  • SDK version: 3.31.0
  • Environment: Sandbox and Production
  • Browser and OS: Windows 10, Firefox 58.0.2, IE 11, Chrome 65, Edge 41

Issue description

when using Roboform to autofill credit card info, hosted fields only takes the first 4 digits VERY ANNOYING. Roboform autofill works with every other non-Braintree site I've encountered.

@crookedneighbor
Copy link
Contributor

My guess is that the fix for this is going to be similar to some issues we had with 1password. Fix for reference.

Probably the extension is doing something non-standard when sending key events, so our formatting library isn't handling it correctly. We'll investigate this. Thanks for the report.

@crookedneighbor
Copy link
Contributor

A little update on this.

The number field in Hosted Fields has some additional inputs hidden inside it to allow native browser autofill to work. For some reason, Roboform is populating each of those fields with part of the credit card number.

If we switch the position styling of the Hosted Fields input from position: absolute; to position: fixed;, it fixes the issue without any noticeable visual change. Seems a little silly to make this change for what looks to be weird behavior by Roboform, but it doesn't seem to have any negative effects to make the change, so we're going to do some further testing and assuming nothing comes up, try to get it out in the next release.

@crookedneighbor crookedneighbor changed the title Credit Card auto fill only fills first 4 digits Credit Card auto fill only fills first 4 digits with Roboform Mar 16, 2018
@crookedneighbor
Copy link
Contributor

This is fixed in v3.32.0

@crookedneighbor
Copy link
Contributor

The fix for this caused an issue in Safari where if the container was hidden (display: none;, and then later revealed (display: block;), the hosted fields inputs wouldn't be visible.

Re-opening this until we can figure out a better work around to support Roboform.

@crookedneighbor
Copy link
Contributor

Just tried this on the latest version of Roboform, and I know longer see the issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants