Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interferogram: interpolated fills #45

Open
brandondube opened this issue Aug 15, 2021 · 1 comment
Open

interferogram: interpolated fills #45

brandondube opened this issue Aug 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@brandondube
Copy link
Owner

At present, the only fill option prysm has is the kludgy constant value fill. This creates discontinuities in data that corrupt spectral estimates. It would be preferred to allow the user to fill zeros with interpolated values. It's not certain whether actual interpolation (scipy.interpolate.interp2d) or something like a polynomial fit would be better. The latter is easier to implement and may be faster.
@brandondube brandondube added the enhancement New feature or request label Aug 15, 2021
@brandondube
Copy link
Owner Author

The current library structure is not very conducive to this as a built in, since it would force a lot of choices on the user. But it is easy to implement/show in the docs as a recipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandondube