Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider React.Fragments as node #55

Open
ArthurBrito opened this issue Aug 13, 2020 · 0 comments
Open

Don't consider React.Fragments as node #55

ArthurBrito opened this issue Aug 13, 2020 · 0 comments

Comments

@ArthurBrito
Copy link

Firstly, thanks for the amazing lib!

I'm trying to achieve some like that:
const ValueItems = () => ( <React.Fragment> ... </React.Fragment> )
<TextLoop interval={4500} adjustingSpeed={300}> <ValuesItems /> </TextLoop>
As ValueItems is used in some places, it makes sense to me to create a component for that, however, to have the use ValueItems in TextLoop is not possible because it's wrapped with <React.Fragment>. The just check one level deep in the children nodes which I understand, however, I think that React.Fragments should be an exception to the rule as Fragments is intended to not be a node, but just a wrapper.

What are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant