Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFGate - anti-ad blocking fix #15

Closed
lukemulks opened this issue Mar 14, 2017 · 2 comments
Closed

SFGate - anti-ad blocking fix #15

lukemulks opened this issue Mar 14, 2017 · 2 comments
Assignees

Comments

@lukemulks
Copy link
Collaborator

SFGate.com has custom ad calls that bypass shield blocking.

Migrated from brave/browser-laptop#6635

At the time the original issue was submitted, I hadn't been familiar with our about:adblock custom filter options, so I had labeled as a siteHacks fix.

The following filter has tested and effectively blocked the ad calls from taking place on sfgate.com with Shields Up.

||aps.hearstnp.com^$script,image

The above filter will also cover the ad calls on other hearst domains, aside from SFGate.com.

I'm going to submit a PR that includes two other filters that were discovered as bypassing shields. Separate issues for those, as they're more global than this hearst-specific case.

@lukemulks
Copy link
Collaborator Author

lukemulks commented Mar 14, 2017

PR #18

@lukemulks
Copy link
Collaborator Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant