Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all filters which blocks the request #344

Open
darahe opened this issue Mar 19, 2024 · 1 comment
Open

Return all filters which blocks the request #344

darahe opened this issue Mar 19, 2024 · 1 comment

Comments

@darahe
Copy link

darahe commented Mar 19, 2024

Is it possible to return all filters in BlockerResult for check_network_request?

pub filter: Option<String>,

adblock-rust/src/engine.rs

Lines 133 to 135 in 3eb8ac0

pub fn check_network_request(&self, request: &Request) -> BlockerResult {
self.blocker.check(request, &self.resources)
}

@darahe
Copy link
Author

darahe commented Mar 20, 2024

@antonok-edm WDYT about introducing a new method? Something like check_all_network_request, but maybe with better naming :)

Or can we expand the existing API to return all filters that match the request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant