New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some statements can be simplified for readability #404

Open

hamirmahal opened this issue Dec 1, 2024 · 0 comments · May be fixed by #405

hamirmahal commented Dec 1, 2024

We can replace lines like

assert!(engine.check_network_request(&request).matched == *expectation,
    "Expected match = {} for {} from {} typed {} against {:?}", expectation, url, source_url, request_type, rules)

with

assert!(engine.check_network_request(&request).matched == *expectation,
    "Expected match = {expectation} for {url} from {source_url} typed {request_type} against {rules:?}")

to improve code readability and developer productivity.

hamirmahal linked a pull request

that will close this issue

style: simplify some statements for readability #405

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment