Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Download history is not cleared on exit #10013

Closed
rEes9P opened this issue May 30, 2020 · 4 comments
Closed

[Desktop] Download history is not cleared on exit #10013

rEes9P opened this issue May 30, 2020 · 4 comments
Labels
closed/duplicate Issue has already been reported

Comments

@rEes9P
Copy link

rEes9P commented May 30, 2020

Description

Clear browsing data > On exit > Download history doesn't work

Steps to Reproduce

  1. Select option Clear browsing data > On exit > Download history in Settings (do not select any of the other options)
  2. Download a file. Quit Brave. Reopen Brave.

Actual result:

Download history is not cleared on exit

Expected result:

Would expect download history to be cleared on exit

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision: 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{hashtag999}
OS: macOS Version 10.14.6 (Build 18G5033)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes

Miscellaneous Information:

Interestingly, if the option Clear browsing data > On exit > Browsing history is selected in addition to Download history then the Download history is cleared. However, the selection of Browsing history shouldn't have a bearing on whether Download history is cleared or not.

@rebron rebron changed the title Download history is not cleared on exit [Desktop] Download history is not cleared on exit Jul 10, 2020
@rebron
Copy link
Collaborator

rebron commented Jul 10, 2020

cc: @LaurenWags When you get a chance, can you see if you can reproduce?
I wasn't able to using 1.11.x RC:

Brave 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS macOS Version 10.16 (Build 20A4300b)

Screen Shot 2020-07-10 at 10 27 20 AM

@rEes9P We might have this already fixed as I'm not able to reproduce in our latest RC that's going out next week.

@LaurenWags
Copy link
Member

@rebron duplicate of #4004

@LaurenWags
Copy link
Member

Does not reproduce using below build for me

Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | macOS Version 10.14.6 (Build 18G3020)

Tried steps from description and steps from #4004

@rebron rebron added closed/duplicate Issue has already been reported and removed OS/Desktop feature/settings labels Jul 17, 2020
@rebron
Copy link
Collaborator

rebron commented Jul 17, 2020

Closing as dupe of #4004 @mkarolin This looks fixed in 1.11.x? Can you confirm? Neither @LaurenWags or me could reproduce.

@rebron rebron closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants