Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Super Referrer - QR Code #10079

Closed
anthonypkeane opened this issue Jun 4, 2020 · 1 comment · Fixed by brave/brave-core#5741
Closed

[Android] Super Referrer - QR Code #10079

anthonypkeane opened this issue Jun 4, 2020 · 1 comment · Fixed by brave/brave-core#5741
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.10.x - Release

Comments

@anthonypkeane
Copy link

Description

Super Referrer (SR) uses an enhanced referrer tracking system. On iOS, we do this by directing users to a landing page and copying a referral code.

The SR link is slightly different to the normal referrer link.

The QR code on the SR custom home page uses the normal referrer link, we need to change this so that URL link for the QR code can be entered in the .json file.

Link: https://bravesoftware.slack.com/archives/CT7JC4KBM/p1591227697202100

iOS issue: brave/brave-ios#2599
@anthonypkeane anthonypkeane added QA/Yes OS/Android Fixes related to Android browser functionality labels Jun 4, 2020
@deeppandya deeppandya mentioned this issue Jun 4, 2020
Merged
32 tasks
@deeppandya deeppandya removed this from the Android 1.10.x Release milestone Jun 4, 2020
@bbondy bbondy added this to the 1.10.x - Release milestone Jun 10, 2020
@srirambv srirambv mentioned this issue Jun 16, 2020
Closed
8 tasks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 17, 2020 •
edited by btlechowski
Loading

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.10.92.apk

  • Verified the test plan from Update QR code url brave-core#5741
  • Verified that the URL https://brave.com/r/OXB363 is sent to the user when code is shared via QR code menu from SR image
  • Verified that click on https://brave.com/r/OXB363 redirected to SR page

Verification passed on BraveModernarm v1.10.92 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verified the test plan from Update QR code url brave-core#5741
  • Verified that the URL https://brave.com/r/OXB363 is sent to the user when code is shared via QR code menu from SR image
  • Verified that click on https://brave.com/r/OXB363 redirected to SR page

@kjozwiak kjozwiak mentioned this issue Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

Update QR code url brave/brave-core
6 participants
@bbondy @kjozwiak @deeppandya @anthonypkeane @btlechowski @GeetaSarvadnya