Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement P2A component for private ad analytics #10081

Closed
moritzhaller opened this issue Jun 4, 2020 · 3 comments · Fixed by brave/brave-core#5949
Closed

Implement P2A component for private ad analytics #10081

moritzhaller opened this issue Jun 4, 2020 · 3 comments · Fixed by brave/brave-core#5949

Comments

@moritzhaller
Copy link

moritzhaller commented Jun 4, 2020

Ticket includes:

  1. Implement a brave component analogous to P3A to enable private ad analytics
  2. Implement dummy question related to ad-confirmations to sanity check reports

Spec:

Related PRs:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 2, 2020

QA Blocked - until the follow-up issue #11552 is fixed

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 2, 2020

Removed QA blocked based on #11552 (comment).

The issue can be tested now as the test plan is precise now.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 2, 2020

Verification passed on


Brave | 1.14.72 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


Verified P2A log for Brave.P2A.ViewConfirmationCount

[3016:9744:0902/232423.349:VERBOSE2:brave_p3a_service.cc(373)] BraveP3AService::OnHistogramChanged: histogram_name = Brave.P2A.ViewConfirmationCount Sample = 2147483646 bucket = 2147483646

Note: P2A host listed in Charles can be tested once issue #11552 is fixed. With the above PR just need to verify logs in the console.


Verified passed with

Brave | 1.14.72 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)
[11310:775:0902/162917.574843:VERBOSE2:brave_p3a_service.cc(373)] BraveP3AService::OnHistogramChanged: histogram_name = Brave.P2A.ViewConfirmationCount Sample = 2147483646 bucket = 2147483646

Per internal discussions, follow up issues #11552 and #11060 are to be addressed separately.


Verification passed on

Brave 1.14.72 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS
[27034:27034:0903/064548.307601:VERBOSE2:brave_p3a_service.cc(373)] BraveP3AService::OnHistogramChanged: histogram_name = Brave.P2A.ViewConfirmationCount Sample = 2147483646 bucket = 2147483646
'''

@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants