Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importable profiles should have additional fields set #104

Closed
garrettr opened this issue Mar 15, 2018 · 0 comments · Fixed by brave/brave-core#15150
Closed

Importable profiles should have additional fields set #104

garrettr opened this issue Mar 15, 2018 · 0 comments · Fixed by brave/brave-core#15150
Assignees
Labels
feature/importer OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@garrettr
Copy link
Contributor

garrettr commented Mar 15, 2018

Updated issue description by @bsclifton

Having access to a few additional fields would let us present a better import experience. For example, the profiles could be grouped by browser, sorted by last used, and the icons associated with each profile could be displayed.

Profile level fields in Local State file

For Chromium profiles, in GetChromeSourceProfiles (common/importer/chrome_importer_utils.cc) we can get the last used time (in epoch format) for each profile. It's stored in the Local State file under the profile with the field active_time. The active profile icon (which would be useful when presenting the profile in the UI) is there under avatar_icon (and the URL will load fine in Brave).

Browser level fields

If the profiles that are importable are grouped by browser, there are some additional fields we could set. For example, last_active_profiles lets us know the last used profile for that browser. It would be useful to know if the browser is the default browser for the OS. Default browser isn't something stored in the file but is something we can test for.

Original issue description

Chrome orders the list of browser profiles that are available for import such that the default browser's profiles appear first in the list. This is convenient because most users are likely to want to import their current browser's settings, and their current browser is probably also the default.

Since Chrome only supports importing from Firefox or the OS's default browser (Safari/Edge/etc.), it is enough to check whether Firefox is the user's default browser or not. Since we've added the option to import Chrome/Chromium/Chrome Canary profiles, we should also check whether Chrome is the default browser and build/sort the list of profiles accordingly.

@garrettr garrettr self-assigned this Mar 15, 2018
@bbondy bbondy added this to the Backlog milestone Jun 6, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 5, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton bsclifton added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Sep 12, 2022
@bsclifton bsclifton changed the title List of profiles available for import should show the default browser's profiles first Importable profiles should have the last used time and boolean for if browser is currently default Sep 12, 2022
@bsclifton bsclifton changed the title Importable profiles should have the last used time and boolean for if browser is currently default Importable profiles should have additional fields set Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/importer OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants