Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two issues with options in Settings / Manage Search Engines #1041

Closed
lukemulks opened this issue Sep 8, 2018 · 4 comments
Closed

Two issues with options in Settings / Manage Search Engines #1041

lukemulks opened this issue Sep 8, 2018 · 4 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@lukemulks
Copy link

Description

Observing two separate issues, both within the Settings / Manage Search Engines page.

Issue 1: Options available within Default search engines

  • I'm not seeing DuckDuckGo listed among the Default Search Engine option.
  • It would be ideal if DDG could be placed toward the top of the list of Default Search Engines.
  • It would also be good if Qwant, and other privacy-oriented search engine options could be featured in the default search engine list.
  • The work for this ^ might already be taking place (I suspect so); flagging as we've made the public announcement of the dev channel build availability, and DDG is a publicly known partner.

Issue 2: Unexpected options under Other search engines

  • Some of the options I see under Other search engines seem unexpected.
  • For example: Github, Google Drive, Infura Blog, KTLA, Socialblade, Twitter
  • The other search engines appear to be related to browsing history, but I wouldn't typically expect any of the examples above to display under search engine settings.
  • Each of the examples listed have search querying available within their domains, but wouldn't typically qualify as search engines at the browser level.

Steps to Reproduce

  1. Enter: chrome://settings/searchEngines

Actual result:

brave-core-settings-search-engines-09082018

Expected result:

  • Brave search engine partners listed among Default search engine options (search engines we've formed structured partnerships with).
  • Other search engine options include search engines submitted from contributors via github.

Reproduces how often:

Easily reproduced

Brave version (about:brave info)


Brave | 0.55.2 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
-- | --
Revision | 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS | Windows
JavaScript | V8 7.0.242
Flash | (Disabled)
User Agent | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3528.4 Safari/537.36

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@lukemulks lukemulks added feature/global-settings Settings at browser level independent of shields settings feature/search labels Sep 8, 2018
@lukemulks
Copy link
Author

cc: @bsclifton (ddg/partner optics - not sure who would be best to assign, but suspect you know) ;-)

@bbondy
Copy link
Member

bbondy commented Sep 9, 2018

I don't think the 2nd thing is an issue, anything that supports open search xml will show up in that list if you hit the site. I think we should add DDG to the list though. Note that people can still configure it, but I think we should just make it easier.

@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

I think the issue is anything that supports open search xml will show up on that list, a list the user doesn't know about or can't clear all at once or as part of clear browsing data. Separate priority from the first issue though.

@bsclifton
Copy link
Member

Closing as a duplicate of #731

@bsclifton bsclifton removed this from the Releasable builds 0.55.x milestone Sep 28, 2018
@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Sep 28, 2018
@bsclifton bsclifton added this to the Dupe / Invalid / Not actionable milestone Sep 28, 2018
@bsclifton bsclifton removed feature/global-settings Settings at browser level independent of shields settings feature/search labels Sep 28, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants