Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent UI reflow on google.com search results in standard adblocking mode #10461

Closed
pes10k opened this issue Jun 24, 2020 · 5 comments · Fixed by brave/brave-core#5991 or brave/brave-core#6028
Assignees
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@pes10k
Copy link
Contributor

pes10k commented Jun 24, 2020

Currently, when brave is in default cosmetic blocking mode, there is jitter on google.com when the 1p search ad is at first hidden, and then un-hidden after the process runs.

This issue is to put in place a short term, hacky fix to not apply ##.ads-ad on https://*.google.*/* (or similar) when brave is in the default blocking mode, to prevent jitter

this is a short term solution for a bigger, more proper default-mode-exceptions component + service

@pes10k pes10k added priority/P3 The next thing for us to work on. It'll ride the trains. privacy-pod Feature work for the Privacy & Web Compatibility pod OS/Desktop labels Jun 24, 2020
@pes10k pes10k added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 24, 2020
@ryanbr
Copy link

ryanbr commented Jun 28, 2020

could we just create google.com#@#.ads-ad in brave-unbreak, would that work?

@irfaneru

This comment has been minimized.

@pes10k
Copy link
Contributor Author

pes10k commented Jun 28, 2020

@irfaneru i am deleting your message because it is unrelated to this tread. https://community.brave.com/ is the right place for that kind of question

@pes10k
Copy link
Contributor Author

pes10k commented Jun 28, 2020

@ryanbr that wouldn't work bc then it would not be applied in strict / 1p blocking mode

@antonok-edm antonok-edm changed the title Create hacky exception in content_cosmetic.ts to not apply .ads-ad cosmetic rule on google.com Prevent UI reflow on google.com search results in standard adblocking mode Jul 6, 2020
@antonok-edm antonok-edm added this to the 1.12.x - Nightly milestone Jul 6, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2020

Verified passed with

Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Reproduced the reflow issue using 1.11.92 on google.com with various searches
  • Verified the test plan from Don't apply #.ads-ad in standard adblocking mode brave-core#5991
  • Confirmed ads appear at the top on google.com searches (for certain searches such as remove my online footprint, samsung galaxy phone, etc) when in Standard mode for trackers & ad blocking. Confirmed the ads appear at the same time as other content, no re-flow was observed.

remove my online footprint - std

samsung galaxy phone - std

delete my online data - std

  • Confirmed ads do not appear at the top on google.com searches (again, used searches as above, from the test plan, and others) when in Aggressive mode for trackers & ad blocking.

remove my online footprint - aggressive

samsung galaxy phone - aggressive

delete my online data - aggressive


Verification passed on


Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

  • Confirmed ads appear at the top on google.com searches (for certain searches such as remove my online footprint, samsung galaxy phone, etc) when in Standard mode for trackers & ad blocking. Confirmed the ads appear at the same time as other content, no re-flow was observed.
    image
    image
    image

  • Confirmed ads do not appear at the top on google.com searches (again, used searches as above, from the test plan, and others) when in Aggressive mode for trackers & ad blocking.
    image
    image
    image


Verification passed on

Brave 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS Ubuntu 18.04 LTS
  • Confirmed ads appear at the top on google.com searches (for certain searches such as remove my online footprint, samsung galaxy phone, etc) when in Standard mode for trackers & ad blocking. Confirmed the ads appear at the same time as other content, no re-flow was observed.
    image

  • Confirmed ads do not appear at the top on google.com searches (again, used searches as above, from the test plan, and others) when in Aggressive mode for trackers & ad blocking.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
8 participants