Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Ads displayed for profile where Ads are off when another profile has ads enabled - follow up to 7441 #10588

Closed
LaurenWags opened this issue Jul 7, 2020 · 1 comment
Assignees
Labels
bug closed/duplicate Issue has already been reported feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include

Comments

@LaurenWags
Copy link
Member

Description

Issue originally reported in #7441 still reproduces.

From #7441:

If a user has a profile with ads/rewards on and one with ads/rewards off, even if a window is not open for the profile with ads on, ad notifications are still presented to the user.

Steps to Reproduce

Scenario 1:

  1. Using 1.10.97 reproduce the issue as described with steps from Ads on/off toggle for different profiles causes confusion when using profile with Ads off #7441 (comment)
  2. Upgrade to 1.11.x
  3. Open window for profile B, browse to a site like brave.com
  4. Close window.
  5. Browse as normal in window for profile A.
  6. Ad notification will be triggered.

Scenario 2 (steps from #7441 (comment)):

  1. Clean profile (Profile A).
  2. Enable Rewards. Now disable Rewards. Leave window for this profile open.
  3. Add another profile (Profile B).
  4. Enable Rewards, set ads to show 5x per hour.
  5. Visit a site like brave.com in Profile B window and then after page loads, close the window for Profile B.
  6. Browse normally on window for Profile A.

Actual result:

You are served ad notifications.

Expected result:

We should respect the profile you are using and not serve ad notifications.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.11.90 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure, probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/legacy_qa @jsecretan @tmancey

@tmancey tmancey self-assigned this Aug 3, 2020
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported labels Aug 3, 2020
@tmancey
Copy link
Contributor

tmancey commented Aug 5, 2020

Duplicate of #11042. @LaurenWags can you please retest as part of #11042

@tmancey tmancey marked this as a duplicate of #11042 Aug 5, 2020
@tmancey tmancey closed this as completed Aug 5, 2020
@tmancey tmancey added the closed/duplicate Issue has already been reported label Aug 5, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/duplicate Issue has already been reported feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Archived in project
Development

No branches or pull requests

2 participants