Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Default search engine setting resets after update #1077

Closed
Sh1d0w opened this issue Sep 10, 2018 · 5 comments
Closed

[BUG] Default search engine setting resets after update #1077

Sh1d0w opened this issue Sep 10, 2018 · 5 comments

Comments

@Sh1d0w
Copy link

Sh1d0w commented Sep 10, 2018

Description

If you set a default search engine different from google, after Brave browser updates it resets this setting to google.

Steps to Reproduce

  1. Install Brave
  2. Set default search engine to duckduckgo
  3. Update Brave to newer version

Expected result:

Default search engine to stay as set before the update

Reproduces how often:

Every time

Brave version (about:brave info)

Version 0.55.2 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)

@bsclifton bsclifton added bug feature/global-settings Settings at browser level independent of shields settings feature/search labels Sep 10, 2018
@bbondy
Copy link
Member

bbondy commented Sep 14, 2018

@srirambv could you try this on the next update? @Sh1d0w let me know if it keeps happening on each update too. Thanks!

@bbondy bbondy added this to the 1.x Backlog milestone Sep 14, 2018
@simonhong
Copy link
Member

I didn't see this bug with recent update on MacOS and Win10.

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 14, 2018

@bbondy The bug was present when updating to 0.55.2, but it seems fixed on 0.55.3.

Closing, Thanks!

@Sh1d0w Sh1d0w closed this as completed Sep 14, 2018
@bbondy
Copy link
Member

bbondy commented Sep 14, 2018

I think it could be something like a shutdown crash so settings aren't flushed.

@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid Sep 14, 2018
@bbondy bbondy removed bug feature/global-settings Settings at browser level independent of shields settings feature/search labels Sep 14, 2018
@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 15, 2018

@bbondy Now that you are saying that, I remember shortly after installed and used it for a while it really crashed but I haven't noticed that settings haven't saved, as the update came right the next day.

Btw the new Brave Browser is great, solves a lot of the problems I have reported before and made me come back. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants