Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tor to /components #1114

Closed
darkdh opened this issue Sep 13, 2018 · 2 comments · Fixed by brave/brave-core#6881
Closed

Move tor to /components #1114

darkdh opened this issue Sep 13, 2018 · 2 comments · Fixed by brave/brave-core#6881
Assignees
@darkdh
Labels
feature/tor OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Milestone
1.18.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Sep 13, 2018

in order to provide BUILDFLAG to build without Tor easily and better dependency graph
@darkdh darkdh self-assigned this Sep 13, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Sep 14, 2018
@bridiver
Copy link
Contributor

side not that the Tor process should be decoupled from profile manager with NOTIFICATION_PROFILE_CREATED and NOTIFICATION_PROFILE_DESTROYED

@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Oct 30, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@darkdh
Copy link
Member Author

darkdh commented Oct 7, 2020

We should also move tor related tests

@darkdh darkdh self-assigned this Oct 7, 2020
@darkdh darkdh mentioned this issue Oct 7, 2020
Merged
33 tasks
@darkdh darkdh mentioned this issue Oct 16, 2020
Merged
33 tasks
@darkdh darkdh added this to the 1.18.x - Nightly milestone Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/tor OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor tor to brave/components brave/brave-core
5 participants
@bridiver @tildelowengrimm @bbondy @rebron @darkdh