Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Greaselion for Vimeo publishers #11465

Closed
NejcZdovc opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#6955
Closed

Use Greaselion for Vimeo publishers #11465

NejcZdovc opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#6955

Comments

@NejcZdovc
Copy link
Contributor

we should switch to GL for Vimeo so that we can have faster turn around rate when something breaks.

@srirambv srirambv changed the title Use GreaseLion for Vimeo publishers [Desktop] Use GreaseLion for Vimeo publishers Sep 9, 2020
@emerick emerick self-assigned this Oct 6, 2020
@emerick emerick removed their assignment Oct 7, 2020
@bsclifton bsclifton changed the title [Desktop] Use GreaseLion for Vimeo publishers [Desktop] Use Greaselion for Vimeo publishers Oct 26, 2020
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 30, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 25, 2020

Verified passed with

Brave	1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.14.6 (Build 18G6042)

Note - Vimeo videos are not added to AC list, this will be solved as part of #12107 / brave/brave-site-specific-scripts#28

Confirmed Brave Local Data Updater version is at least 1.0.38:

Screen Shot 2020-11-25 at 9 39 53 AM

Vimeo user URL

Verified test plan from brave/brave-core#6955 using vimeo.com/bravelaurenwags on staging env

Confirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo. Note - favicon is still incorrect and this has been logged with #12781.

Screen Shot 2020-11-25 at 9 40 25 AM

Confirmed able to tip as expected.

Screen Shot 2020-11-25 at 9 40 46 AM Screen Shot 2020-11-25 at 9 40 55 AM Screen Shot 2020-11-25 at 9 41 02 AM Screen Shot 2020-11-25 at 9 41 10 AM Screen Shot 2020-11-25 at 9 41 22 AM

Confirmed custom tip banner shows (if applicable).

Screen Shot 2020-11-25 at 9 41 38 AM

Confirmed correct publisher information for a non-verified Vimeo creator.

Screen Shot 2020-11-25 at 9 42 47 AM

Confirmed tip to non-verified Vimeo creator goes to pending list as expected.

Screen Shot 2020-11-25 at 9 42 57 AM Screen Shot 2020-11-25 at 9 43 06 AM Screen Shot 2020-11-25 at 9 43 18 AM
Vimeo video URL

Verified test plan from brave/brave-core#6955 using https://vimeo.com/354953087 on staging env

Confirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo.

Screen Shot 2020-11-25 at 9 47 27 AM

Confirmed able to tip as expected.

Screen Shot 2020-11-25 at 9 47 57 AM Screen Shot 2020-11-25 at 9 48 10 AM Screen Shot 2020-11-25 at 9 48 22 AM Screen Shot 2020-11-25 at 9 48 31 AM Screen Shot 2020-11-25 at 9 48 42 AM

Confirmed custom tip banner shows (if applicable).

Screen Shot 2020-11-25 at 9 47 49 AM

Confirmed correct publisher information for a non-verified Vimeo creator.

Screen Shot 2020-11-25 at 9 49 28 AM

Confirmed tip to non-verified Vimeo creator goes to pending list as expected.

Screen Shot 2020-11-25 at 9 49 37 AM Screen Shot 2020-11-25 at 9 49 46 AM Screen Shot 2020-11-25 at 9 49 58 AM
Excluded URLs

Verified test plan from brave/brave-core#6955

Confirmed excluded URL https://vimeo.com/watch shows vimeo.com in the panel

Screen Shot 2020-11-25 at 9 56 30 AM

Confirmed tip goes to Pending list (as Vimeo is not verified on staging env)

Screen Shot 2020-11-25 at 9 57 29 AM

Spot checked other excluded URLs, confirmed vimeo.com shows in the panel:

Screen Shot 2020-11-25 at 9 58 16 AM Screen Shot 2020-11-25 at 9 58 38 AM Screen Shot 2020-11-25 at 9 58 57 AM
History

Verified test plan from brave/brave-core#6955

Visited multiple user and video URLs in the same tab. Confirmed panel updated as expected with creator information. Confirmed after using back/forward navigation buttons the panel updated as expected with creator information.

Tab Activation

Verified test plan from brave/brave-core#6955

Visited multiple user and video URLs in different tabs. Confirmed panel updated as expected with creator information. Confirmed after activating/focusing on a tab/switching between tabs the panel updated as expected with creator information.

Tipping non-Vimeo Publishers

Tipping various publisher types was accomplished under #6462 (comment)


Verification passed on


Brave | 1.18.65 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)


Confirmed Brave Local Data Updater version is at least 1.0.38:
image

Vimeo user URL Verified test plan from brave/brave-core#6955 using vimeo.com/bravelaurenwags on staging env

Confirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo. Note - favicon is still incorrect and this has been logged with #12781.
image

Confirmed able to tip as expected.
image
image
image
image
image

Confirmed custom tip banner shows (if applicable).
image

Confirmed correct publisher information for a non-verified Vimeo creator.
image

Confirmed tip to non-verified Vimeo creator goes to pending list as expected.
image
image
image

Vimeo video URL Verified test plan from brave/brave-core#6955 using https://vimeo.com/354953087 on staging env

Confirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo.
image
Confirmed able to tip as expected.
image
image
image
image
image

Excluded URL's Verified test plan from brave/brave-core#6955

Confirmed excluded URL https://vimeo.com/watch shows vimeo.com in the panel
image

Confirmed tip goes to Pending list (as Vimeo is not verified on staging env)
image
image

Spot checked other excluded URLs, confirmed vimeo.com shows in the panel:
image
image
image

History Verified test plan from brave/brave-core#6955

Visited multiple user and video URLs in the same tab. Confirmed panel updated as expected with creator information. Confirmed after using back/forward navigation buttons the panel updated as expected with creator information.

Tab Activation Verified test plan from brave/brave-core#6955

Visited multiple user and video URLs in different tabs. Confirmed panel updated as expected with creator information. Confirmed after activating/focusing on a tab/switching between tabs the panel updated as expected with creator information.

Tipping non-Vimeo Publishers Tipping various publisher types will be covered in #6462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants