-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Greaselion for Vimeo publishers #11465
Comments
Verified passed with
Note - Vimeo videos are not added to AC list, this will be solved as part of #12107 / brave/brave-site-specific-scripts#28 Confirmed Vimeo user URLVerified test plan from brave/brave-core#6955 using vimeo.com/bravelaurenwags on staging env Confirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo. Note - favicon is still incorrect and this has been logged with #12781. ![]() Confirmed able to tip as expected. ![]() ![]() ![]() ![]() ![]() Confirmed custom tip banner shows (if applicable). ![]() Confirmed correct publisher information for a non-verified Vimeo creator. ![]() Confirmed tip to non-verified Vimeo creator goes to pending list as expected. ![]() ![]() ![]() Vimeo video URLVerified test plan from brave/brave-core#6955 using https://vimeo.com/354953087 on staging env Confirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo. ![]() Confirmed able to tip as expected. ![]() ![]() ![]() ![]() ![]() Confirmed custom tip banner shows (if applicable). ![]() Confirmed correct publisher information for a non-verified Vimeo creator. ![]() Confirmed tip to non-verified Vimeo creator goes to pending list as expected. ![]() ![]() ![]() Excluded URLsVerified test plan from brave/brave-core#6955 Confirmed excluded URL https://vimeo.com/watch shows vimeo.com in the panel ![]() Confirmed tip goes to Pending list (as Vimeo is not verified on staging env) ![]() Spot checked other excluded URLs, confirmed vimeo.com shows in the panel: ![]() ![]() ![]() HistoryVerified test plan from brave/brave-core#6955 Visited multiple user and video URLs in the same tab. Confirmed panel updated as expected with creator information. Confirmed after using back/forward navigation buttons the panel updated as expected with creator information. Tab ActivationVerified test plan from brave/brave-core#6955 Visited multiple user and video URLs in different tabs. Confirmed panel updated as expected with creator information. Confirmed after activating/focusing on a tab/switching between tabs the panel updated as expected with creator information. Tipping non-Vimeo PublishersTipping various publisher types was accomplished under #6462 (comment) Verification passed on
Confirmed Vimeo user URLVerified test plan from brave/brave-core#6955 using vimeo.com/bravelaurenwags on staging envConfirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo. Note - favicon is still incorrect and this has been logged with #12781. Confirmed able to tip as expected. Confirmed custom tip banner shows (if applicable). Confirmed correct publisher information for a non-verified Vimeo creator. Confirmed tip to non-verified Vimeo creator goes to pending list as expected. Vimeo video URLVerified test plan from brave/brave-core#6955 using https://vimeo.com/354953087 on staging envConfirmed that correct publisher information is displayed in the panel. Confirmed verified checkmark displays on BAT logo. Excluded URL'sVerified test plan from brave/brave-core#6955Confirmed excluded URL https://vimeo.com/watch shows vimeo.com in the panel Confirmed tip goes to Pending list (as Vimeo is not verified on staging env) Spot checked other excluded URLs, confirmed vimeo.com shows in the panel: HistoryVerified test plan from brave/brave-core#6955Visited multiple user and video URLs in the same tab. Confirmed panel updated as expected with creator information. Confirmed after using back/forward navigation buttons the panel updated as expected with creator information. Tab ActivationVerified test plan from brave/brave-core#6955Visited multiple user and video URLs in different tabs. Confirmed panel updated as expected with creator information. Confirmed after activating/focusing on a tab/switching between tabs the panel updated as expected with creator information. Tipping non-Vimeo PublishersTipping various publisher types will be covered in #6462 |
we should switch to GL for Vimeo so that we can have faster turn around rate when something breaks.
The text was updated successfully, but these errors were encountered: