Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block private browsing mode detection #11543

Closed
antonok-edm opened this issue Sep 1, 2020 · 2 comments · Fixed by brave/brave-core#6622
Closed

Block private browsing mode detection #11543

antonok-edm opened this issue Sep 1, 2020 · 2 comments · Fixed by brave/brave-core#6622
Assignees
@antonok-edm
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.18.x - Release

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Sep 1, 2020 •
edited
Loading

A number of websites use the navigator.storage.estimate() API to detect users in private browsing mode. That API returns a hard-limited quota of 120MB in private browsing, and larger values otherwise.

This has been proposed in Chromium, but appears to be a wontfix as the quota is intended to be kept fully in-memory for private browsing sessions.

There are several options here, including increasing the available quota as a temporary workaround, or simply lying about the available space (it is an estimate, after all!).

Edit: for future reference, the QA pass for Android below was completed using the following HTML:

<html>
    <body>
    <script>
        navigator.storage.estimate().then(estimate => alert(estimate.quota))
    </script>
    </body>
</html>
@antonok-edm antonok-edm added privacy OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 1, 2020
@antonok-edm antonok-edm self-assigned this Sep 1, 2020
@antonok-edm antonok-edm mentioned this issue Sep 10, 2020
Merged
32 tasks
@fmarier
Copy link
Member

fmarier commented Sep 11, 2020

Here's the approach that Bromite took: https://github.com/bromite/bromite/blob/master/build/patches/Hardening-against-incognito-mode-detection.patch

@pes10k pes10k added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 15, 2020
@antonok-edm antonok-edm mentioned this issue Oct 28, 2020
Closed
@antonok-edm antonok-edm added this to the 1.18.x - Nightly milestone Nov 3, 2020
@srirambv
Copy link
Contributor

srirambv commented Nov 27, 2020 •
edited by btlechowski
Loading

Verification passed on the following devices running 1.18.63 x64 beta build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)
oneplusinspect samsunginspect
  • Verified on a private tab shows the same size

Verification passed on


Brave | 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Normal Tab:
image

Private Tab
image

Guest window
image

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Normal Tab:
image

Private Tab
image

@LaurenWags LaurenWags mentioned this issue Dec 8, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Bypass private browsing mode detection brave/brave-core
6 participants
@pes10k @fmarier @srirambv @antonok-edm @btlechowski @GeetaSarvadnya