Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cosmetic filters on Android (scriplets injection) #11599

Closed
SergeyZhukovsky opened this issue Sep 4, 2020 · 1 comment · Fixed by brave/brave-core#6581
Closed

Comments

@SergeyZhukovsky
Copy link
Member

Description

Currently we hardcode scripts that need to be injected in pages like YT for example to avoid some kind of ads, we want to improve that and pull the needed scripts from adblock list like we do when we block specific URLs.

We had ads on such embedded videos https://www.pcmag.com/news/the-best-vr-games-for-2019. We just need to make sure that we don't have them when apply the fix for this issue.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.16.65 x64 build

  • Verified no ads shown on videos on the page
  • Verified no ads on embedded YT videos as well

Verification passed on Samsung Tab A with Android 10 running 1.16.65 x64 build

  • Verified no ads shown on videos on the page
  • Verified no ads on embedded YT videos as well

@rebron rebron changed the title [Android] Implement cosmetic filters on Android (scriplets injection) Implement cosmetic filters on Android (scriplets injection) Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment