Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UrlCosmeticResources methods into main adblock instance #11600

Closed
antonok-edm opened this issue Sep 4, 2020 · 1 comment
Closed

Move UrlCosmeticResources methods into main adblock instance #11600

antonok-edm opened this issue Sep 4, 2020 · 1 comment
Assignees
@antonok-edm
Labels
closed/duplicate Issue has already been reported dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop
Milestone
Closed / Dupe / I...

Comments

@antonok-edm
Copy link
Collaborator

Followup to brave/brave-core#6581 (comment).

As part of brave/brave-core#6452, the regional and custom filters services were moved into the main adblock service instance. Android is gaining support for scriptlet injections, which use UrlCosmeticResources. This method currently accesses all three adblock engines globally and merges them at the API level. To reduce code duplication and make additional progress towards #5461, this functionality should all be handled from within the main adblock service.
@antonok-edm antonok-edm added dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 4, 2020
@antonok-edm antonok-edm self-assigned this Sep 4, 2020
@antonok-edm antonok-edm mentioned this issue Sep 4, 2020
Merged
32 tasks
@antonok-edm antonok-edm added the closed/duplicate Issue has already been reported label Mar 18, 2021
@antonok-edm antonok-edm added this to the Closed / Dupe / Invalid milestone Mar 18, 2021
@antonok-edm
Copy link
Collaborator Author

This has been fixed in the process of supporting cosmetic filters on Android 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
closed/duplicate Issue has already been reported dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
1 participant
@antonok-edm