Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Crash from playstore build #11625

Closed
deeppandya opened this issue Sep 8, 2020 · 1 comment · Fixed by brave/brave-core#6591
Closed

[Android] Crash from playstore build #11625

deeppandya opened this issue Sep 8, 2020 · 1 comment · Fixed by brave/brave-core#6591

Comments

@deeppandya
Copy link

Description

Below is the error stack fro the crash :
Caused by: java.lang.IllegalStateException:
at androidx.fragment.app.FragmentManager.checkStateLoss (FragmentManager.java:1703)
at androidx.fragment.app.FragmentManager.enqueueAction (FragmentManager.java:1743)
at androidx.fragment.app.BackStackRecord.commitInternal (BackStackRecord.java:321)
at androidx.fragment.app.BackStackRecord.commit (BackStackRecord.java:286)
at androidx.fragment.app.DialogFragment.show (DialogFragment.java:181)
at org.chromium.chrome.browser.brave_stats.BraveStatsUtil.showBraveStats (BraveStatsUtil.java:69)
at org.chromium.chrome.browser.BraveActivity.checkForBraveStats (BraveActivity.java:31
at org.chromium.chrome.browser.notifications.retention.RetentionNotificationPublisher.onReceive (RetentionNotificationPublisher.java:53)

Steps to reproduce

  1. Fresh install for 1.13
  2. from the initial screen, don't enable privacy reports from the onboarding and put the app in the background by pressing home button
  3. Wait for the 3 hour notification and click on the notification would crash the app

Actual result

It should not crash the app.

Expected result

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.13

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

srirambv commented Sep 10, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.86 x64 build

  • Verified steps from issue description
  • Verified no crash when opening notification
  • Verified logs doesn't contain any crash

Verification passed on Samsung Tab A with Android 10 running 1.13.86 x64 build

  • Verified steps from issue description
  • Verified no crash when opening notification
  • Verified logs doesn't contain any crash

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.13.86 BraveModernx86.apk

  • Reproduced the issue using 1.13.83
  • Verified steps from issue description
  • Verified no crash when opening notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants