Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Auto rotate is off but screen is rotating after 1.13.85 update #11632

Closed
newuser-web opened this issue Sep 9, 2020 · 10 comments · Fixed by brave/brave-core#6650
Closed
Assignees
Labels

Comments

@newuser-web
Copy link

newuser-web commented Sep 9, 2020

Description

Auto rotate is off but screen is rotating in brave browser

Steps to reproduce

  1. Turn off Auto rotate
  2. Open any website

Actual result

It's rotating screen

Expected result

It shouldn't rotate screen

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet): phone
  • Android version: 9

Brave version 1.13.85

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@newuser-web newuser-web added the OS/Android Fixes related to Android browser functionality label Sep 9, 2020
@srirambv srirambv added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Sep 9, 2020
@newuser-web
Copy link
Author

@srirambv Do you need any more information from me?

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2020

Am not sure I understand the issue. Would it be possible to do a screen recording of the issue?

@srirambv
Copy link
Contributor

@newuser-web
Copy link
Author

@srirambv Clicking the newly added privacy report icon causes this problem.

@jonathansampson
Copy link
Contributor

jonathansampson commented Sep 11, 2020

Another user (using 1.13.85) experiencing this behavior notified us through Twitter. At this time, the Tweet includes a video as well.

I was unable to reproduce the issue on 1.12.113 and 1.16.7 on my Pixel 3 XL running Android 10.

@newuser-web
Copy link
Author

I'm facing this issue after 1.13.85 update. To reproduce this bug click on the privacy report icon , after that come back on the homepage of brave and then change the orientation of the phone.

@urbenlegend
Copy link

I am also getting this issue whenever I press the Privacy Reports icon and then close the panel that pops up. I am running 1.13.87 on a Pixel 2XL.

@intrnl
Copy link

intrnl commented Sep 16, 2020

Isn't this related to #11059?

Brave Stats/Privacy Reports causing rotation lock to no longer be honored

@kjozwiak kjozwiak added bug QA/Yes release-notes/include and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Sep 16, 2020
@bsclifton bsclifton added this to the 1.16.x - Nightly milestone Sep 16, 2020
@bsclifton
Copy link
Member

bsclifton commented Sep 16, 2020

Added missing milestone after fix was merged 😄 👍

Adding P3 label (we can let ride the trains). If we need it sooner, let's bump to a P2 and uplift 😄

@srirambv
Copy link
Contributor

srirambv commented Sep 17, 2020

Verification passed on OnePlus 6T with Android 10 running 1.14.83 x64 build

  • Verified on GPS build even without enabling privacy report and auto-rotate turned off changing device orientation auto-rotates the browser
  • Verified upgrading to 1.14.83, with auto-rotate turned off changing device orientation doesn't auto-rotate the browser with or without privacy report being enabled

Verification passed on OnePlus 6T with Android 10 running 1.14.83 x64 build

  • Verified on GPS build even without enabling privacy report and auto-rotate turned off changing device orientation auto-rotates the browser
  • Verified upgrading to 1.14.83, with auto-rotate turned off changing device orientation doesn't auto-rotate the browser with or without privacy report being enabled

Verification passed on Nexus 6P Emulator with Android 7 running 1.14.83 x86 build

  • Verified on GPS build even without enabling privacy report and auto-rotate turned off changing device orientation auto-rotates the browser
  • Verified upgrading to 1.14.83, with auto-rotate turned off changing device orientation doesn't auto-rotate the browser with or without privacy report being enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants