Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German translation for "Customize" to customize dashboard is truncated #12044

Closed
ff2000 opened this issue Oct 8, 2020 · 9 comments · Fixed by brave/brave-core#25221
Closed

German translation for "Customize" to customize dashboard is truncated #12044

ff2000 opened this issue Oct 8, 2020 · 9 comments · Fixed by brave/brave-core#25221
Assignees
@mkarolin
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.69.x - Release

Comments

@ff2000
Copy link

ff2000 commented Oct 8, 2020

Screenshot_20201008_093936

The issue is here:

https://github.com/brave/brave-core/blob/e2559f894b8afdf20f7cc0873618760b56036c70/components/resources/strings/brave_components_resources_de.xtb#L30

Instead of "Anpa" it should be "Anpassen"
@bsclifton bsclifton added the l10n label Oct 9, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 23, 2020
@rebron
Copy link
Collaborator

rebron commented Nov 23, 2020

@btlechowski When you get a chance can you check this one on 1.17.73?

@btlechowski
Copy link

Reproduced on all channels

Brave 1.17.73 Chromium: 87.0.4280.67 (Official Build) (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Ubuntu 18.04 LTS
Brave 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Ubuntu 18.04 LTS

image

@btlechowski
Copy link

Still reproducible

Brave 1.24.16 Chromium: 89.0.4389.105 (Official Build) nightly (64-bit)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS Ubuntu 18.04 LTS

image
image

@btlechowski
Copy link

Still reproducible

Brave 1.40.19 Chromium: 101.0.4951.41 (Official Build) nightly (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Ubuntu 18.04 LTS

image

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to On Deck in General May 28, 2024
@btlechowski
Copy link

Still reproducible

Brave 1.68.137 Chromium: 127.0.6533.100 (Official Build) (64-bit)
Revision 2c62ca4f207eb8f02406936d1e5a4b226ddcfd3a
OS Linux

image

@rebron
Copy link
Collaborator

rebron commented Aug 13, 2024

cc: @zenparsing @mkarolin

@mkarolin
Copy link
Contributor

Updated translations in Transifex. Will pull it in with the 1.69.x release.

@rebron rebron moved this from On Deck to In progress in General Aug 14, 2024
@mkarolin mkarolin mentioned this issue Aug 19, 2024
Merged
24 tasks
@kjozwiak kjozwiak added this to the 1.69.x - Release milestone Aug 20, 2024
@github-project-automation github-project-automation bot moved this from In progress to Completed in General Aug 20, 2024
@kjozwiak
Copy link
Member

The above requires 1.69.149 or higher for 1.69.x verification 👍

This was referenced Aug 20, 2024
Merged
Merged
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 20, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Aug 20, 2024 •
edited
Loading

Verified with

Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (x86_64)
-- | --
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | macOS Version 13.6.9 (Build 22G830)

Confirmed "Anpassen" was displayed for "Customize" on NTP:

german

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 20, 2024
@rebron rebron removed this from General Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Updated l10n for 1.69.x release (lowered to master) brave/brave-core
7 participants
@ff2000 @kjozwiak @bsclifton @rebron @LaurenWags @btlechowski @mkarolin