Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overarching error page (Crypto Wallets) #12119

Closed
ryanml opened this issue Oct 13, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#184
Closed

Remove overarching error page (Crypto Wallets) #12119

ryanml opened this issue Oct 13, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#184

Comments

@ryanml
Copy link
Contributor

ryanml commented Oct 13, 2020

Currently, in the case of certain JS errors, an error notice will overtake the entire application, with no clear path to resolution for the user. This was added upstream in MetaMask/metamask-extension#7889

Well of course reports of errors should be taken seriously, users should still be able to access their recovery keys and other portions of the app, in the event one portion of it errors out. This diff should effectively be reverted.

Test Plan

  1. Perform a general regression test, ensuring that this error page does not appear. (Alternatively, manually build the codebase with an error purposefully introduced, and ensure this page does not show)
@srirambv
Copy link
Contributor

srirambv commented Nov 9, 2020

This is fixed on current release component 1.0.23. Didnt see any issue while going over manual pass. Marking as QA/No and moving to release milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants