Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap ad serving to not exceed the maximum ads per week/month for a creative set #12316

Closed
tmancey opened this issue Oct 26, 2020 · 1 comment · Fixed by brave/brave-core#7332
Closed

Cap ad serving to not exceed the maximum ads per week/month for a creative set #12316

tmancey opened this issue Oct 26, 2020 · 1 comment · Fixed by brave/brave-core#7332
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.26.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 26, 2020

No description provided.

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Oct 26, 2020
@tmancey tmancey changed the title Implement MonthlyMax frequency capping to limit ad serving Implement PerMonth frequency capping to limit ad serving Oct 27, 2020
@tmancey tmancey mentioned this issue Dec 3, 2020
Merged
23 tasks
@tmancey tmancey self-assigned this Mar 8, 2021
@tmancey tmancey changed the title Implement PerMonth frequency capping to limit ad serving Cap ad serving to not exceed per day/month on a per creative set basis Mar 12, 2021
@tmancey tmancey changed the title Cap ad serving to not exceed per day/month on a per creative set basis Cap ad serving to not exceed the maximum ads per day/month for a creative set Mar 12, 2021
@tmancey tmancey changed the title Cap ad serving to not exceed the maximum ads per day/month for a creative set Cap ad serving to not exceed the maximum ads per week/month for a creative set Mar 29, 2021
@tmancey tmancey added this to the 1.26.x - Nightly milestone Apr 30, 2021
@btlechowski btlechowski added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Test-All-Platforms labels Jun 1, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.26.53 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/775

ads per week - blocked for 1 week

1st ad shown:

[32560:32560:0608/105324.029455:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 54eae24a-2186-46e9-8b9e-8e0b5966e3f9
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: perWeek = 1
  body: perWeek = 1
  targetUrl: https://youtube.com

2nd ad blocked:


[1990:1990:0614/105645.467241:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b has exceeded the frequency capping for perWeek

ads per week - released after 1 week

Ad is shown after 1 week of being blocked

[3756:3756:0615/105830.232785:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 2920e29c-a0f5-4848-b359-c49ced92b2e3
  creativeInstanceId: 5b4cb3f4-5285-4597-87c5-3082fe37938a
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: perWeek = 1
  body: perWeek = 1
  targetUrl: https://youtube.com

ads per week - non-limited ads keep showing

1st ad shown

[6555:6555:0608/133620.861365:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 486b6f62-0697-4537-a445-9e8f7d081a78
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: perWeek = 0
  body: perWeek = 0
  targetUrl: https://youtube.com

2nd ad shown

[7319:7319:0608/141109.403375:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: ac0ade6b-d557-4c53-bb20-e2c6ca861691
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: perWeek = 1
  body: perWeek = 1
  targetUrl: https://youtube.com

After 6 days, perWeek = 0 is shown and perWeek = 1 is blocked

[8453:8453:0613/141428.655679:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
 uuid: 406bb8fa-bcd7-40cc-97f3-0e9783446c69
 creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
 creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
 campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
 advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
 segment: untargeted
 title: perWeek = 0
 body: perWeek = 0
 targetUrl: https://youtube.com
[8453:8453:0613/141428.594306:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId 5e96fecc-2926-4c72-bb76-4e745bf6b539 has exceeded the frequency capping for perWeek

ads per month - blocked for 1 month

1st ad shown:

[9440:9440:0608/135505.046512:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 550e8380-9fd9-48c4-87e4-80784417aa09
  creativeInstanceId: 5b4cb3f4-5285-4597-87c5-3082fe37938a
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: perMonth = 1
  body: perMonth = 1
  targetUrl: https://youtube.com

Blocked after 28 days

[17802:17802:0705/153241.928759:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b has exceeded the frequency capping for perMonth

ads per month - released after 1 month

Ad was shown

[18203:18203:0709/153844.495323:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 50c2941e-ecde-41d3-a4c2-692db7555465
  creativeInstanceId: 5b4cb3f4-5285-4597-87c5-3082fe37938a
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: perMonth = 1
  body: perMonth = 1
  targetUrl: https://youtube.com

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 8, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.26.x - Release
Development

Successfully merging a pull request may close this issue.

Implement PerWeek/PerMonth frequency capping to limit ad serving brave/brave-core
2 participants
@tmancey @btlechowski