Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today news feed on the New Tab Page #12574

Closed
petemill opened this issue Nov 8, 2020 · 6 comments · Fixed by brave/brave-core#6192
Closed

Brave Today news feed on the New Tab Page #12574

petemill opened this issue Nov 8, 2020 · 6 comments · Fixed by brave/brave-core#6192

Comments

@petemill
Copy link
Member

petemill commented Nov 8, 2020

Description

Introduce Brave Today - a privacy-focused feed of articles with on-device local-only personalization.

Privacy features:

  • Every user downloads the same feed.
  • Personalization options are on-device only and not sent anywhere outside the local browser.
  • Network MITM observers will not be able to see which content is being viewed since images are all the same size (padded) and transmitted over HTTPS.

Content Types

There are different types of card:

Large Article
image

2 Articles
image

Deals
image

Category List
image

Publisher List
image

Test Plan

When the OS is set to any english language region, Brave Today is on by default

  1. OS set to US
  2. Fresh profile
  3. Open NTP
  4. Brave Today is visible
  5. Brave Today is on in the Customize dialog on the NTP

image

When the OS is set to any **non-**english language region, Brave Today is off by default

  1. OS set to France
  2. Fresh profile
  3. Open NTP
  4. Brave Today is not visible
  5. Brave Today is off in the Customize dialog on the NTP, but can successfully be turned off

image

Feed scrolls

When Brave Today is on, at any window width, the user can scroll down and the Brave Today feed items appear, on top of all other NTP content.

NTP content fades out

When Brave Today content appears, all other NTP content fades (and blurs) away.

More content loads

The feed is split in to many pages. After scrolling through about 25 items, another 'page' should load automaticall, normally without the user's scroll hitting the bottom. Images for those new items should also load.
The order of content that repeats, after the initial 1 large article and 1 deals card, is:

  Large Article,
  Large Article,
  Two Articles,
  Two Articles,
  CategoryGroup,
  Large Article,
  Deals,
  Large Article,
  Two Articles,
  PublisherGroup,
  Large Article,
  Two Articles
  Large Article,
  Two Articles,
  Large Article,

Publishers can be turned off

  1. Scroll down to Brave Today content
  2. Observe -> "Customize" button should appear in bottom-right of Viewport and should stay fixed position during scrolling
  3. Click "Customize"
    --> Observe: When clicking the "Customize" button, the NTP Settings popup should open, on top of all other NTP / Brave Today content.
    --> Observe: There should be a list of categories as well as "all sources".
  4. Click a category
    --> Observe: There should be a list of publishers with Toggles, some on and some off by default.
  5. Change Toggles
    --> Observe: Toggle changes when clicked
  6. Close settings popup
    --> Observe: If a toggle for a publsiher with content was changed there should be a "Load New Content" blue "pill" button should appear at the top of the Viewport.
  7. Clicking the "Load New Content" button should refresh the feed with the publisher's content removed.

Feed can refresh

Handles no internet connection

  1. Fresh profile + any English OS region
  2. Disconnect from network (wireless or wired)

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 7, 2020

Verification passed on

Brave | 1.18.69 Chromium: 87.0.4280.88 (Official Build) (64-bit)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | Windows 10 OS Version 2004 (Build 19041.630)

  • Verified the test plan mentioned in the description

  • Verified that Brave Today is ON and visible in NTP when OS is set to any English language
    image

  • Verified that Brave Today is off by default and which is not shown in NTP's when the OS is set to any non-English language Kannada,
    image
    image

Brave Today Feed scrolls - different windows size
  • Verified that in all the windows width and resolutions Brave Today feeds are shown and aligned (Centered) properly.
  • Verified that in all the windows width and resolutions Brave Today feeds can be viewed and scrolled properly.

Display resolution 1920x1080 - 125%

image
image
image

Display resolution 1680x1050 - 125%
image
image
image

Display resolution 1440x900 - 100%
image
image
image
image

Display resolution 1024x768 - 100%
image
image
image

Display resolution 800x600 - 100%
image
image
image

NTP content fades out
  • Verified that when Brave Today content appears, all other NTP content fades (and blurs) away. Verified in both light and dark mode

image
image

  • Open any Brave Today feed in NTP and restart the browser, verified that the opened brave today feed is presented to the user after the browser restart
More content loads Test
  • Verified that the feed is split into many pages. After scrolling through about 25 items
  • Verified that feeds pages are loaded automatically without the user's hitting the scrolling bottom.
  • Verified the order of content that repeats, after the initial 1 large article and 1 deals card

Large Article
image

image

Two articles
image

Category list
image

Publisher list
image

image

Publishers can be turned off
  1. Verified that "Customize" button appeared at the bottom right corner of the Brave Today feed

  2. Verified that "Customize" button appeared at the bottom-right of Viewport is in a fixed position during scrolling
    image

  3. Clicked on the "Customize" button and verified that the NTP settings popup opened up on the Brave Today feeds.

  4. Verified "Customize" settings popup contains the list of categories as well as "all sources".
    image

  5. Clicked on Category and verified that there is a list of publishers with Toggles, some ON and some OFF by default.
    image

  6. Verified that toggles can be turned ON and OFF

  7. Verified that toggles changes were retained when settings popup is opened and closed

  8. Verified that toggles changes were retained when the browser is restarted

  9. Change the toggle to ON for a few lists in a category and close the settings popup and verified that the "Load New Content" blue "pill" button appeared at the top of the Viewport.
    image

  10. Verified that clicking the "Load New Content" button refreshed the feed with the publisher's content removed.

  11. Verified that when few lists in a category are selected or toggled ON and clicked on "Load New Content" blue "pill" button refresh the feeds

Handles no internet connection

@GeetaSarvadnya
Copy link

@petemill - when Wifi/Internet is OFF, launch brave isn't showing message as Brave Today is experiencing some issues. Try again instead, it shows spinner.

image

@petemill
Copy link
Member Author

petemill commented Dec 9, 2020

@GeetaSarvadnya Eventually the spinner should go away and the message shown. It may be some minutes. Is that your experience?

@GeetaSarvadnya
Copy link

@petemill The message isn't shown even after ~15 mins. Logged #13109

@rudolphos
Copy link

rudolphos commented Dec 11, 2020

Suggestion: option to add custom RSS feeds.

@bsclifton
Copy link
Member

@rudolphos subscribe to #13095 for updates regarding custom RSS feed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment