Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ad received this month" is not translated #13032

Closed
btlechowski opened this issue Dec 3, 2020 · 1 comment
Closed

"Ad received this month" is not translated #13032

btlechowski opened this issue Dec 3, 2020 · 1 comment

Comments

@btlechowski
Copy link

Follow up to #12719

Steps to Reproduce

  1. Run Brave in German(DE) locale
  2. Enable rewards
  3. Open brave://rewards

Actual result:

Ad received this month is not translated
image

Expected result:

Ad received this month is translated

Reproduces how often:

Easily reproduced

Desktop Brave version:

Brave 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Ubuntu 18.04 LTS
Brave 1.20.5 Chromium: 87.0.4280.67 (Official Build) nightly (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @rebron @mkarolin @brave/legacy_qa

@btlechowski
Copy link
Author

btlechowski commented Jan 18, 2021

Verification passed on

Brave 1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
Revision 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS Ubuntu 18.04 LTS

Verified test plan from the description

German
image


Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.85 Chromium: 88.0.4324.89 (Official Build) (x86_64)
--- | ---
Revision | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS | macOS Version 11.1 (Build 20C69)

Bildschirmfoto 2021-01-18 um 7 15 16 PM


Verification passed on


Brave | 1.19.85 Chromium: 88.0.4324.89 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
Betriebssystem | Windows 10 OS Version 2004 (Build 19041.746)


  • Verified the STR from the description
    image

Verification PASSED on Samsung S10+ running Android 10 using the following build:

1.19.86 Chromium: 88.0.4324.96

Screenshot_20210119-140337_Brave


Verification PASSED on Samsung Galaxy Tablet A running Android 10 using the following build:

1.19.86 Chromium: 88.0.4324.96

Screenshot_20210119-145803_Brave

@btlechowski btlechowski added this to the 1.19.x - Release milestone Jan 18, 2021
@kjozwiak kjozwiak changed the title Ad received this month is not translated "Ad received this month" is not translated Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants