"Brave.Today.WeeklyMaxCardVisitsCount" P3A metric doesn't work - Follow up to #12974 #13096

[kjozwiak]

Description

As per #12974, Brave.Today.WeeklyMaxCardVisitsCount should log the amount of cards that have been clicked per Brave Today session. However, Brave.Today.WeeklyMaxCardVisitsCount isn't appearing under brave://local-state after clicking on several cards.

Values/Buckets for Brave.Today.WeeklyMaxCardVisitsCount can be found via the #12974 (comment).

Steps to Reproduce

1. install/launch the latest Nightly (1.20.17 Chromium: 87.0.4280.88 in this case)
2. once launched, open a NTP and click a few Brave Today cards
3. visit brave://local-state and you'll notice Brave.Today.WeeklyMaxCardVisitsCount isn't being added into P3A metrics

Actual result:

Brave.Today.WeeklyMaxCardVisitsCount isn't being added into brave://local-state

Expected result:

Brave.Today.WeeklyMaxCardVisitsCount should be added into brave://local-state when the criteria is met

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.20.17 Chromium: 87.0.4280.88 (Official Build) nightly (64-bit)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | Windows 10 OS Version 2009 (Build 19042.630)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @petemill

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.630)

• launched 1.18.70 CR: 87.0.4280.101
• ensured that opening cards via CTRL + Click worked as expected
• ensured that opening cards by clicking on them via NTP and going back to NTP via back button worked as expected
• clicked on several different type of cards via the Brave Today feed
  • single cards, text on lists, Companion products

1 card clicked per session:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": false,
   "value": "1"

2-3 card clicked per session:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": false,
   "value": "2"

4-6 card clicked per session:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": false,
   "value": "3"

7-10 card clicked per session:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": false,
   "value": "4"

11-15 card clicked per session:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": false,
   "value": "5"

15+ card clicked per session:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": false,
   "value": "6"

Ensured the data was being sent as per the following:

"Brave.Today.WeeklyMaxCardVisitsCount": {
   "sent": true,
   "timestamp": 1607540207.137938,
   "value": "6"