Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Brave page" like indicator for IPFS schemes #13172

Closed
bbondy opened this issue Dec 11, 2020 · 3 comments · Fixed by brave/brave-core#8234
Closed

Add a "Brave page" like indicator for IPFS schemes #13172

bbondy opened this issue Dec 11, 2020 · 3 comments · Fixed by brave/brave-core#8234
Assignees
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Dec 11, 2020

This issue was broken out from @jessicaschilling's issue posted here: #13125

Screen Shot 2020-12-11 at 4 39 03 PM

Other than looking at the address bar, it would be good to show when the user is using their local IPFS node via. aURL bar indicator similar to the Brave one.

Clicking on IPFS icon here could open brave://ipfs diagnostic page (or a better UI in the future).
A better UI would be a flyout view that has information about the connection.

@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Dec 11, 2020
@bbondy bbondy changed the title Add a Brave like indicator for IPFS schemes Add a "Brave page" like indicator for IPFS schemes Dec 11, 2020
@jessicaschilling
Copy link

jessicaschilling commented Dec 12, 2020

+1 for a flyout view here! Content in the flyout could be something like ...

Resources loaded over IPFS
One or more resources on this site were loaded using your IPFS node, which is currently connected to XX peers. Learn more

It's also important to consider that there may be cases in which a page might display both another informational icon - maybe a "secure padlock" and an IPFS cube, or the "Not Secure" message and an IPFS cube. There's an opportunity here to make a decision that will ultimately impact every browser 😊 in a way that the original addition of the "secure padlock" icon did ... so this is definitely worth some careful thought before implementing. Would be very happy to be more deeply involved here once you're ready to move this into your active list.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 13, 2021
@spylogsster spylogsster self-assigned this Mar 12, 2021
@spylogsster
Copy link

The first PR for the badge created brave/brave-core#8234 and security review for this https://github.com/brave/security/issues/368

The dialog would change incrementally after with separate security issue

@stephendonner
Copy link

Verified PASSED using nightly build

Brave 1.24.11 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Checked:

  1. shows up for both ipfs and ipns URLs: ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html, ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/, ipns://brantly.eth, ipns://en.wikipedia-on-ipfs.org, on both dark and light themes
Example Example Example Example Example Example
Screen Shot 2021-03-22 at 1 25 09 PM Screen Shot 2021-03-22 at 1 25 28 PM
  1. shows up for interstitial-installation page

  1. doesn't show up for brave://ipfs-internals pages
Example Example
Screen Shot 2021-03-22 at 11 55 34 AM Screen Shot 2021-03-22 at 11 56 30 AM
  1. doesn't show up for https://en-wikipedia--on--ipfs-org.ipns.dweb.link/wiki/ and https://en.wikipedia-on-ipfs.org/wiki/
Example Example
Screen Shot 2021-03-22 at 12 31 03 PM Screen Shot 2021-03-22 at 12 31 11 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants