Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a warning that some sites don't work over Tor #1351

Closed
srirambv opened this issue Sep 29, 2018 · 2 comments
Closed

Show a warning that some sites don't work over Tor #1351

srirambv opened this issue Sep 29, 2018 · 2 comments
Assignees
@diracdeltas
Labels
closed/invalid closed/wontfix

Comments

@srirambv
Copy link
Contributor

Description

Show a warning that some sites don't work over Tor

Steps to Reproduce

  1. Open Tor Window
  2. Visit a site and open shields
  3. No warning message that some sites dont work over Tor

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS All

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added security feature/tor design A design change, especially one which needs input from the design team browser-laptop-parity labels Sep 29, 2018
@srirambv srirambv added this to the Releasable builds 0.55.x milestone Sep 29, 2018
@srirambv srirambv mentioned this issue Sep 29, 2018
Closed
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 (0.56.x) Sep 29, 2018
@bbondy
Copy link
Member

bbondy commented Sep 29, 2018

moving to 1.x

@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog Sep 29, 2018
@diracdeltas diracdeltas modified the milestones: 1.x Backlog, 1.0 (0.56.x) Sep 29, 2018
@tildelowengrimm
Copy link
Contributor

This functionality is covered by the new tab page for Privacy Windows with Tor. I don't think we should target a separate Shields edit for this.

@tildelowengrimm tildelowengrimm modified the milestones: 0.56.x, Dupe / Invalid / Not actionable Oct 11, 2018
@kjozwiak kjozwiak removed browser-laptop-parity design A design change, especially one which needs input from the design team feature/tor security labels Oct 19, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
closed/invalid closed/wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@diracdeltas @tildelowengrimm @bbondy @kjozwiak @srirambv