"Publisher: Unknown" field of the go-ipfs "Windows Defender" prompt

[kjozwiak]

Description

When launching/enabling IFPS on Windows via the onboarding for the first time, you'll get the following Windows Defender prompt:

However, if you take a look at go-ipfs_v0.7.0_windows-amd64, you'll notice that its signed:

Steps to Reproduce

1. download/install https://github.com/brave/brave-browser/releases/tag/v1.21.7
2. load https://dweb.link/ipfs/bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
3. click on Enable IPFS

Actual result:

Probably shouldn't be prompting users.

Expected result:

Shouldn't be prompting the user similar to Tor.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.21.7 Chromium: 88.0.4324.87 (Official Build) nightly (64-bit)
-- | --
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | Windows 10 OS Version 2009 (Build 19042.746)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bbondy @brave/legacy_qa @rebron

[GeetaSarvadnya]

The issue isn't reproducible in 1.19.84. However, I am able to reproduce the issue in Nightly channel 1.21.7 Dev 1.20.81 and Beta 1.19.80

[bbondy]

The dialog is expected, I think for the Publisher: Unknown part, this is a signing problem:
https://stackoverflow.com/a/10587106

[kjozwiak]

Received it again on my main Win 10 x64 machine. It looks like the users Allow decision expires and you'll eventually be prompted again as per the following:

Installed the following Nightly version and was prompted the above (even though I've allowed access a while ago)

Brave | 1.27.16 Chromium: 91.0.4472.70 (Official Build) nightly (64-bit)
--- | ---
Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS | Windows 10 OS Version 2009 (Build 19042.964)

[spylogsster]

@stephendonner @kjozwiak can we please recheck this with latest node 0.9.0?

[stephendonner]

@stephendonner @kjozwiak can we please recheck this with latest node 0.9.0?

Re-checked with

Brave	1.28.74 Chromium: 92.0.4515.93 (Official Build) nightly (64-bit)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	Windows 10 OS Version 2009 (Build 22000.65)

and Version: go-ipfs/0.9.0/ - can't reproduce the issue, just see a "choose default handler" OS dialog pop-up.

[kjozwiak]

I can still reproduce this on my clean Win 10 x64 VM using the following build:

Brave | 1.27.109 Chromium: 92.0.4515.115 (Official Build) (64-bit)
--- | ---
Revision | 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

The VM that I'm using has never had Brave installed. Once I visited ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html, I got the following prompt from Win:

[bbondy]

I believe Lidel is in the process of signing the IPFS binaries for the next go-ipifs release, so I think this will be improved after that.

[kjozwiak]

Still appearing with go-ipfs/0.9.1. I know @bbondy mentioned that we're in the process of signing the IPFS binaries, but figured I would mention that it's still happening in go-ipfs/0.9.1 in case users/anyone else runs into this on their machine. Example:

This time it actually happened on my personal work desktop which had Brave installed a million times before.

[kjozwiak]

Still an issue and received using 1.48.49 Chromium: 108.0.5359.99 when go-ipfs_v0.17.0 was pushed out as per the following:

[srirambv]

Seems to be same when installing IPFS installer for desktop at least one of the prompt has an unknown publisher message.