Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI on brave://ipfs for tweaking Datastore.StorageMax #13720

Closed
lidel opened this issue Jan 22, 2021 · 3 comments · Fixed by brave/brave-core#8149
Closed

Add UI on brave://ipfs for tweaking Datastore.StorageMax #13720

lidel opened this issue Jan 22, 2021 · 3 comments · Fixed by brave/brave-core#8149
Assignees

Comments

@lidel
Copy link

lidel commented Jan 22, 2021

Brave v1.19 ships with StorageMax set to 1GB by default:

	"Datastore": {
		"GCPeriod": "1h",
		"StorageGCWatermark": 90,
		"StorageMax": "1GB"

I've been asked by multiple users how to increase this limit.

Right now they need to:

  1. go to http://127.0.0.1:45001/webuiSettings OR find the config file on the disk
  2. change the StorageMax value and save the config
  3. restart the node to apply the config change

I suggest we improve this common operation by adding two UI on the brave://ipfs (or proposed brave://settings/ipfs) page:

  • <input type="number" that defines the number of GB read from the config file
  • "Apply" button that updates value in config + restarts the node.

cc @autonome @jessicaschilling @bbondy

@lidel lidel changed the title Add UI on brave://ipfs tweaking Datastore.StorageMax Add UI on brave://ipfs for tweaking Datastore.StorageMax Jan 22, 2021
@bbondy
Copy link
Member

bbondy commented Jan 22, 2021

I think maybe in the chrome://settings page in its new section will be better, but ++ on the option.

@jessicaschilling
Copy link

Makes sense to me.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 26, 2021
@spylogsster spylogsster self-assigned this Mar 3, 2021
@bbondy bbondy added this to the 1.23.x - Nightly milestone Mar 10, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 10, 2021
@stephendonner
Copy link

Verified PASSED using nightly build on macOS:

Brave 1.23.31 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS macOS Version 11.2.3 (Build 20D91)

13720-steps.md

Maximum IPFS cache size (GB) value StorageMax value
0 0
1 1000000000
9999 9999000000000
99999 99999000000000
99999999 99999990000000000
999999999 999999999000000000
9999999999 0

Verified:

  • Maximum IPFS cache size (GB) input box only appears when Local node is set as the resolver in Method to resolve IPFS resources via brave://settings

  • typically (there are instances which I am still investigating where it doesn't) when the user changes the value, it is soon reflected via brave://ipfs

  • not able to input non-numeric characters

  • Value must be greater than or equal to 1 tooltip appears in textbox, correctly, on hover over bad input

  • up and down arrows increment and decrement input value by 1 each press, respectively

  • the upper bounds for a non-zero StorageMax value is 9999999999

  • leading characters such as 09 are accepted and not stripped, but reflect correctly in StorageMax, e.g. 9000000000 for 09

ipfs-storage

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants