Fix adblocking regression for requests made by Service Workers #13781
Labels
feature/shields/adblock
Blocking ads & trackers with Shields
OS/Desktop
privacy-pod
Feature work for the Privacy & Web Compatibility pod
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Description
Resource that should be blocked, according to the custom filters, doesn't get blocked when requested by a service worker.
Steps to Reproduce
||bad.third-party.site^
to the 'Custom Filters' textareaActual result:
"serviceworker-fetch" test is green meaning that request to
https://bad.third-party.site/privacy-protections/request-blocking/block-me/fetch.json?serviceworker-…
has been successfully made. This can be additionally verified using DevTools:Expected result:
All tests should be gray meaning that all requests to
bad.third-party.site
failed to load.Brave version (brave://version info)
Brave | 1.19.86 Chromium: 88.0.4324.96 (Official Build) (x86_64)
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 11.1 (Build 20C69)
Miscellaneous Information:
I haven't verified if this issue only affects custom filters or if it's a more general gap that also affects the default protections.
The text was updated successfully, but these errors were encountered: