Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Accessibility problems #13802

Open
iefremov opened this issue Jan 27, 2021 · 0 comments
Open

Investigate Accessibility problems #13802

iefremov opened this issue Jan 27, 2021 · 0 comments
Labels
OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@iefremov
Copy link
Contributor

Follow-up to #13778

We fixes a crash occured in accessibilityAttributedStringForRange, this function is called by MacOS for different elements of the browser UI. For some reason, MacOS calls it for Tabs, and in this unfortunate case the requested string cannot be obtained:

- (id)AXValue {
  ax::mojom::Role role = _node->GetData().role;
  if (role == ax::mojom::Role::kTab)
    return [self AXSelected];

for kTab it returns the result of [self AXSelected], which is a bool, it crashes accessibilityAttributedStringForRange

We have to figure out why this happens at all, because Chrome doesn't look affected

@rebron rebron added OS/Desktop crash priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 5, 2021
@iefremov iefremov added priority/P3 The next thing for us to work on. It'll ride the trains. and removed crash priority/P2 A bad problem. We might uplift this to the next planned release. labels May 14, 2021
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P3 Backlog in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Status: P3 Backlog
Development

No branches or pull requests

2 participants