Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Brave Web Store" in brave://apps #13881

Closed
fmarier opened this issue Feb 2, 2021 · 5 comments · Fixed by brave/brave-core#7859
Closed

"Brave Web Store" in brave://apps #13881

fmarier opened this issue Feb 2, 2021 · 5 comments · Fixed by brave/brave-core#7859

Comments

@fmarier
Copy link
Member

fmarier commented Feb 2, 2021

If I open brave://apps, I see a tile for the non-existent Brave Web Store:
Screenshot from 2021-02-01 16-29-27
and a link in the footer of the same page:
Screenshot from 2021-02-01 16-30-39

Brave version (brave://version info)

Brave	1.21.36 Chromium: 88.0.4324.96 (Official Build) nightly (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Linux
@rebron
Copy link
Collaborator

rebron commented Feb 3, 2021

I'm not seeing this on Windows or macOS strangely enough in 1.19.x or 1.21.42

@bsclifton
Copy link
Member

Shows for me on Windows (Nightly; 1.21.42). It's hardcoded into there - you can also see it on brave://new-tab-page

On our new tab page, we have a check to explicitly remove this:
https://github.com/brave/brave-core/blob/54603a0626bfb8ac374aba99e27c4192960c27c3/browser/ui/webui/new_tab_page/instant_service_message_handler.cc#L34-L36

@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. good first issue and removed OS/Linux labels Feb 5, 2021
@bsclifton
Copy link
Member

@simonhong I think you recently fixed this when doing the top sites work, right? It's not showing up anymore under brave://apps 😄

@simonhong
Copy link
Member

@bsclifton yes it's fixed by https://github.com/brave/brave-core/pull/7859/files#diff-3814b2ac1912127b98976d12107ad701113cf010e44bbcde74d1822ba9377377R251.
It's not visible anymore since 1.23.x Closed.

@stephendonner
Copy link

Verified PASSED using

Brave 1.23.25 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS macOS Version 11.2.3 (Build 20D91)

Verified that the Brave Web Store no longer appears in nightly via brave://apps

Screen Shot 2021-03-09 at 5 01 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants