Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAP cutoff date isn't correctly detected #14092

Closed
LaurenWags opened this issue Feb 10, 2021 · 6 comments · Fixed by brave/brave-core#7924
Closed

BAP cutoff date isn't correctly detected #14092

LaurenWags opened this issue Feb 10, 2021 · 6 comments · Fixed by brave/brave-core#7924
Assignees
@zenparsing
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.21.x - Release #3

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #13701 / brave/brave-core#7698

Unable to claim staging UGP grant when in Japan region.

Steps to Reproduce

  1. Clean profile on Nightly w/ region = Japan and staging env
  2. Click on Rewards icon and enable Rewards
  3. No UGP grant.

Actual result:

No UGP grant is offered. See the below in logs:

[7846:775:0210/113532.139689:VERBOSE1:promotion.cc(113)] Fetch promotions disabled for BAP migration

Expected result:

Since date has not been met, UGP grant should be available

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.22.16 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS macOS Version 10.15.7 (Build 19H512)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @zenparsing @Miyayes
@LaurenWags LaurenWags added bug feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 10, 2021
@LaurenWags LaurenWags mentioned this issue Feb 10, 2021
Merged
23 tasks
@zenparsing zenparsing mentioned this issue Feb 10, 2021
Merged
23 tasks
@LaurenWags

This comment has been minimized.

Sign in to view
@brave-builds brave-builds mentioned this issue Feb 11, 2021
Merged
7 tasks
@zenparsing zenparsing added this to the 1.22.x - Nightly milestone Feb 12, 2021
@kjozwiak
Copy link
Member

Going to need to recheck this quickly we uplift it into 1.21.x 👍 Removing QA Pass-macOS so it doesn't get missed.

@srirambv

This comment has been minimized.

Sign in to view
@bsclifton bsclifton mentioned this issue Feb 19, 2021
Merged
23 tasks
@bsclifton bsclifton mentioned this issue Feb 26, 2021
Merged
@kjozwiak
Copy link
Member

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2021 •
edited by btlechowski
Loading

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2009 (Build 19042.844)

Region: Japan & Language: English

Example Example Example
eng1 eng2 eng3 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/5d1ab283-6fbc-4e68-bfad-8b2a472b8088
> Result: Success
> HTTP Code: 200

Region: Japan & Language: Japan

Example Example Example
japa1 japa2 japa3 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/8fe2f8e9-89ff-4b2c-b71d-08c3ec7dfc6b
> Result: Success
> HTTP Code: 200

Verified passed with

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	macOS Version 10.15.7 (Build 19H524)

Region: Japan & Language: English

Example Example Example Example
English1 English2 English3 English4 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/2321f82d-e47a-41e8-b73a-653ea8006b7e
> Result: Success
> HTTP Code: 202

Region: Japan & Language: Japan

Example Example Example Example
Japan1 Japan2 Japan3 Japan4 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/fc62b06b-1495-4ed6-b2b0-3ad725c7e2a5
> Result: Success
> HTTP Code: 202

Verification passed on

Brave 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

---------------|-----------------
image|image

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/e59a209c-309d-47d9-b176-28d283a1a0ac
> Result: Success
> HTTP Code: 202

@srirambv
Copy link
Contributor

srirambv commented Mar 11, 2021 •
edited
Loading

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

  • Verified able to claim grant for Locale US
   [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/c8a0d23e-0e5b-45f2-a554-546bb2172dd6
    > Result: Success
    > HTTP Code: 200
  • Verified able to claim grant for Locale Japanese
image image image image 
[ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"2e61f61e-d4f4-400b-90d1-e3ab18c3b50a"}
2021-03-11 08:09:05.280 20957-20957/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/2e61f61e-d4f4-400b-90d1-e3ab18c3b50a
    > Method: UrlMethod::GET
2021-03-11 08:09:05.543 20957-20957/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/2e61f61e-d4f4-400b-90d1-e3ab18c3b50a
    > Result: Success
    > HTTP Code: 200

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

  • Verified able to claim grant for Locale US
image image image image 
 2021-03-11 09:02:51.970 12229-12229/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9"}
2021-03-11 09:02:52.009 12229-12229/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9
    > Method: UrlMethod::GET
2021-03-11 09:02:52.296 12229-12229/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9
    > Result: Success
    > HTTP Code: 200
  • Verified able to claim grant for Japanese Locale
image image image image 
2021-03-11 08:48:33.906 6514-6514/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"df77bc65-f5b2-47dd-9ab2-848ed02f2221"}
2021-03-11 08:48:33.932 6514-6514/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/df77bc65-f5b2-47dd-9ab2-848ed02f2221
    > Method: UrlMethod::GET
2021-03-11 08:48:34.209 6514-6514/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/df77bc65-f5b2-47dd-9ab2-848ed02f2221
    > Result: Success
    > HTTP Code: 200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21.x - Release #3
Development

Successfully merging a pull request may close this issue.

Fix BAP date calculation brave/brave-core
7 participants
@stephendonner @kjozwiak @zenparsing @srirambv @LaurenWags @btlechowski @GeetaSarvadnya