Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking the "FAQ" link within "Add Funds" should open a new tab #1414

Closed
kjozwiak opened this issue Oct 3, 2018 · 2 comments · Fixed by brave/brave-ui#188
Closed

clicking the "FAQ" link within "Add Funds" should open a new tab #1414

kjozwiak opened this issue Oct 3, 2018 · 2 comments · Fixed by brave/brave-ui#188

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 3, 2018

Description

When viewing the Add funds to your Brave wallet under chrome://rewards/, clicking on the FAQ link will open the page within the same tab which is a bit annoying. If a new user wants to quickly read through the FAQ's, they'll need to navigate back to chrome://rewards/ in a new tab.

Steps to Reproduce

  1. launch b-c on either 0.54.x (currently dev) or 0.55.x (currently beta)
  2. visit chrome://rewards/ and enable rewards
  3. once enabled, click on Add Funds
  4. click on FAQ at the bottom of the page

Actual result:

The FAQ page loads within the same tab. A user that wants to read the FAQ and switch back and forth will either need to use the navigation buttons or open a new tab and navigate back to chrome://rewards/.

Expected result:

The FAQ page should open in a new tab.

Reproduces how often:

100% reproducible using the above STR.

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Happens on both of the following build:

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
Brave 0.56.1 Chromium: 70.0.3538.22 (Official Build) dev (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • Does it reproduce on browser-laptop?

N/A - However, links like this always opened in new tabs under about:preferences#payments when using b-l.

@Bad-Science
Copy link

Opened brave/brave-ui#188.

Thanks for the good labeling.

@NejcZdovc NejcZdovc modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 7, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 8, 2018
@kjozwiak
Copy link
Member Author

kjozwiak commented Oct 10, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment