Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion pages are opened in Normal Windows #14188

Closed
btlechowski opened this issue Feb 16, 2021 · 3 comments · Fixed by brave/brave-core#8055
Closed

Onion pages are opened in Normal Windows #14188

btlechowski opened this issue Feb 16, 2021 · 3 comments · Fixed by brave/brave-core#8055

Comments

@btlechowski
Copy link

After clicking Open in Tor, the onion page is opened in Normal Window

Steps to Reproduce

Steps:

  1. Clean install
  2. Open Tor window and wait for initialization
  3. In normal Window open brave.com
  4. Click Open in Tor

tor_onion_page

Actual result:

The onion page is opened in normal window
image

Expected result:

The onion page is opened in tor window

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.22.26 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @jumde @diracdeltas

@rebron
Copy link
Collaborator

rebron commented Feb 23, 2021

cc: @darkdh

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 23, 2021
@LaurenWags
Copy link
Member

Could not reproduce on the following versions on macOS x64 10.15.7

Release

Brave | 1.20.108 Chromium: 88.0.4324.182 (Official Build) (x86_64)
-- | --
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | macOS Version 10.15.7 (Build 19H512)

Beta

Brave | 1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (x86_64)
-- | --
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | macOS Version 10.15.7 (Build 19H512)

Nightly

Brave | 1.22.42 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | macOS Version 10.15.7 (Build 19H512)

@btlechowski
Copy link
Author

btlechowski commented Mar 10, 2021

Verification passed on

Brave 1.23.25 Chromium: 89.0.4389.86 (Official Build) nightly (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image
image

Verification passed on

Brave 1.23.54 Chromium: 89.0.4389.105 (Official Build) beta (x86_64)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS macOS Version 11.2.3 (Build 20D91)

Verified test plan from the description

Tor tab initialized brave.com in normal tab loading brave.com in Tor tab loaded https://brave5t5rjjg3s6k.onion/ in Tor tab
Screen Shot 2021-03-29 at 3 28 38 PM Screen Shot 2021-03-29 at 3 28 43 PM Screen Shot 2021-03-29 at 3 28 48 PM Screen Shot 2021-03-29 at 3 28 58 PM

Verification passed on


Brave | 1.23.56 Chromium: 89.0.4389.105 (Official Build) dev (64-bit)
-- | --
Revision | 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified test plan from the description
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment