Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS link called from command line don't load in Brave window #14283

Closed
Szczerbo opened this issue Feb 22, 2021 · 7 comments
Closed

IPFS link called from command line don't load in Brave window #14283

Szczerbo opened this issue Feb 22, 2021 · 7 comments

Comments

@Szczerbo
Copy link

Description

When trying to call ipfs link from commad line on Windows(don't know how its behave on onther systems) it only opens new Brave window but with no content.

Steps to Reproduce

  1. Fire command (from command prompt) -> "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html

Actual result:

Brave window will appear but with no contet

Expected result:

New Brave window with ipfs content loaded

Reproduces how often:

Easy to reproduce - its permanent

Brave version (info found on brave://version)

Version 1.20.108 Chromium: 88.0.4324.182 (Official Build) (64-bit)

@Szczerbo
Copy link
Author

Found workaround for this specific case.

According to IPFS docs, If You have installed and active IPFS Node, You can simply call ipfs resources as http link - web browser will redirect You to requested resource.

Sample command (Windows cmd) - just paste it and hit "Enter":
"C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" http://bafybeicgmdpvw4duutrmdxl4a7gc52sxyuk7nz5gby77afwdteh3jc5bqa.ipfs.localhost:8080/wiki/Mars.html

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 15, 2021
@spylogsster spylogsster self-assigned this Mar 15, 2021
@spylogsster
Copy link

it works for me in last nightly, @Szczerbo could you please recheck?

@Szczerbo
Copy link
Author

Szczerbo commented Mar 16, 2021

it works for me in last nightly, @Szczerbo could you please recheck?

did double check right now, and still have this same problem. Few days ago did some tests on clean install of Brave and also on VM with fresh Windows installation and brave, and had this same problem.

@spylogsster
Copy link

@Szczerbo could you share screenshot of your brave://settings/ipfs ?

@Szczerbo
Copy link
Author

@Szczerbo could you share screenshot of your brave://settings/ipfs ?

ofc. -> here is .png https://file.io/8XSJEaYmS2dX

@spylogsster
Copy link

@Szczerbo it says file deleted

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 16, 2021

Verification passed on


Brave | 1.24.65 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.867)

  • Verified the STR from the description and ensured IPFS link called from cmd line opens up brave with IPFS content
    IPFS from cmd line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants