Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ads are not displayed while viewing a fullscreen video #14337

Closed
hudson-newey opened this issue Feb 24, 2021 · 3 comments
Closed

Brave Ads are not displayed while viewing a fullscreen video #14337

hudson-newey opened this issue Feb 24, 2021 · 3 comments
Labels
closed/duplicate Issue has already been reported enhancement feature/ads feature-request OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@hudson-newey
Copy link

Description

When watching Youtube or any other fullscreen videos (such as twitch), the user is not shown any Brave Reward alerts/notifications. This may be intentional (as to not irritate the user). Although, many users (including myself) would like to see this as a toggleable option (through the Brave Reward settings panel).

Steps to Reproduce

  1. Enable Brave Rewards
  2. Go to Youtube
  3. No brave reward alerts will show while in fullscreen

Actual result:

No Brave Reward alerts are shown while in Youtube's (and other video sites) fullscreen mode

Expected result:

Give the user the opportunity to enable brave rewards while watching videos in fullscreen mode

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.20.108 Chromium: 88.0.4324.182 (Official Build) (64-bit)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS Windows 10 OS Version 2004 (Build 19041.746)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Haven't tested
  • Can you reproduce this issue with the nightly channel? Haven't tested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Haven't tested
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Does not have required features
@hudson-newey hudson-newey changed the title Brave Reward popups are not showing in youtube fullscreen (Desktop only) Brave Reward popups are not showing in fullscreen videos (Desktop only) Feb 24, 2021
@rebron
Copy link
Collaborator

rebron commented Mar 1, 2021

cc: @jsecretan, @tmancey
This is working as expected.
Not sure if this would be a popular setting that other users would want to turn on. It would also be default off obviously.

@tmancey
Copy link
Contributor

tmancey commented Mar 1, 2021

Based upon feedback from users this would be a good option and as you say with the default off.

@jsecretan jsecretan added the priority/P4 Planned work. We expect to get to it "soon". label Mar 1, 2021
@tmancey tmancey changed the title Brave Reward popups are not showing in fullscreen videos (Desktop only) Brave Ads are not displayed while viewing a fullscreen video Mar 13, 2021
@tmancey tmancey added enhancement closed/duplicate Issue has already been reported labels Mar 13, 2021
@tmancey
Copy link
Contributor

tmancey commented Mar 16, 2021

Closing as duplicate of #9264

@tmancey tmancey closed this as completed Mar 16, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported enhancement feature/ads feature-request OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
Archived in project
Development

No branches or pull requests

4 participants