Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards setup panel is not translated #14368

Closed
btlechowski opened this issue Feb 25, 2021 · 2 comments
Closed

Rewards setup panel is not translated #14368

btlechowski opened this issue Feb 25, 2021 · 2 comments

Comments

@btlechowski
Copy link

Follow up to #13379

Steps to Reproduce

  1. Clean install
  2. Run Brave in Polish (PL) locale

Rewards Panel
3. Open the rewards panel
4. Click "Start using Rewards"
5. Click Let's take a quick tour
6. Go through the tour till Rewards setup panel is shown

Rewards Page
3. Navigate to brave://rewards
4. Click "Start using Rewards"
5. Click Let's take a quick tour
6. Go through the tour till Rewards setup panel is shown

Tip Dialog
3. Navigate to https://twitter.com/kamiljozwiak
4. Click Napiwek (Tip) on a tweet
5. Click "Start using Rewards"
6. Click Let's take a quick tour
7. Go through the tour till Rewards setup panel is shown

Actual result:

Rewards setup panel is not translated

Rewards Panel
image

Rewards Page
image

Tip Dialog
image

Expected result:

Rewards setup panel is not translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

cc @brave/legacy_qa @rebron @mkarolin

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2021

As per #14369 (comment), moving issue into https://github.com/brave/brave-browser/milestone/167 now that brave/brave-core#8093 was merged into 1.22.x and 1.21.x via brave/brave-core#8096 & brave/brave-core#8097.

@brave/legacy_qa if it's still an issue, please re-open and remove it from the milestone as there was no code associated with the issues so we can just re-open then and decide if it's release blocking or not.

@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 2, 2021
@kjozwiak kjozwiak closed this as completed Mar 2, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 2, 2021

Verification passed on


Brave | 1.21.71 Chromium: 89.0.4389.72 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
Betriebssystem | Windows 10 OS Version 2004 (Build 19041.804)

  • Ensured Ads setup panel is translated in Germany and France locales

Germany

BR panel
image

Rewards settings page
image

Tipping banner
image

France
BR panel
image

Rewards settings page
image

Tipping banner
image


Verification passed on

Brave 1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Polish PL locale
Rewards Panel
image

Rewards Page
image

Tip Dialog
image


Verified passed with

Brave | 1.21.71 Chromium: 89.0.4389.72 (Build oficial) (x86_64)
-- | --
Revisión | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
Sistema operativo | macOS Versión 10.15.7 (Compilación 19H512)

Verified STR using Spanish (Spain).

Rewards Panel brave://rewards page Tip Banner
panel rewards page tip dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants