Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENS support #14477

Closed
yrliou opened this issue Mar 4, 2021 · 2 comments · Fixed by brave/brave-core#8125
Closed

Add ENS support #14477

yrliou opened this issue Mar 4, 2021 · 2 comments · Fixed by brave/brave-core#8125

Comments

@yrliou
Copy link
Member

yrliou commented Mar 4, 2021

Support the name resolution of ethereum name service (ENS) via https://resolver.cloudflare-eth.com/dns-query endpoint when the feature is enabled in brave://flags and user set the resolve method to public DoH server.
This issue is to support the same as we have for unstoppable domains in #14099 for ENS, and for .eth TLDs only.

@yrliou yrliou self-assigned this Mar 4, 2021
@bbondy bbondy added this to the 1.23.x - Nightly milestone Mar 6, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 8, 2021
@stephendonner
Copy link

stephendonner commented Mar 8, 2021

Verified FIXED using nightly with the testplan from brave/brave-core#8125 on build

Brave 1.23.23 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.3 (Build 20D91)
  1. Open Brave and visit brantly.eth, it should show error page saying This site can’t be reached.
screenshot Screen Shot 2021-03-08 at 2 28 14 PM
  1. Go to settings, search for ens, there should be no ens domains resolve method setting.
screenshot Screen Shot 2021-03-08 at 2 29 13 PM
  1. Go to brave://flags and search for unstoppable and enable the feature flag.
screenshot Screen Shot 2021-03-08 at 2 29 45 PM
  1. Restart browser and go to brantly.eth should now should the interstitial for users to opt-in unstoppable domains support.
screenshot Screen Shot 2021-03-08 at 2 31 40 PM
  1. Click Disable, should now see site can't be reached and Method to resolve unstoppable domains in brave://settings should now be Disabled.
screenshots Screen Shot 2021-03-08 at 2 31 51 PM Screen Shot 2021-03-08 at 2 32 07 PM
  1. Change the resolve method setting back to ask and visit brantly.eth again.
screenshot Screen Shot 2021-03-08 at 2 35 01 PM
  1. Opt-in interstitial should be shown again, and this time click Proceed using Cloudflare server.
  2. Page should be loaded now. (Note that there will be a brief moment that it is showing site is not reached while the page is loading, this is a known and will be addressed in a new issue.)
screenshot Screen Shot 2021-03-08 at 2 35 20 PM
  1. Method to resolve Ethereum Name Services (ENS) in brave://settings should now be Public DNS over HTTP server.
screenshot Screen Shot 2021-03-08 at 2 37 06 PM
  1. Open a new tab and visit brantly.eth, page should be loaded normally without any interstitial pages.
screenshot

Additionally, I filed #14478 for the cropped Public DNS over HTTPS serv text in the select widget.


Verification passed on

Brave 1.22.66 Chromium: 89.0.4389.90 (Official Build) (64-bit)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS Ubuntu 18.04 LTS
  1. Open Brave and visit brantly.eth and ensured opt-in interstitial page is opened (as per the issue description Do not show opt-in page for decentralized DNS support in OTR contexts #14488 (comment))
screenshot ![image](https://user-images.githubusercontent.com/34715963/111987995-316e9380-8b10-11eb-89d7-5a2e88de1182.png)
  1. Go to settings, search for unstoppable, there is Method to resolve Ethereum Name Service ENS settings set to Ask by default
screenshot

image

  1. Ensured that open http://brantly.eth/ in normal tab is showing up This site can’t be reached page when Method to resolve Ethereum Name Service ENS is set to Disable in brave://settings
screenshot

image

6,7 and 8. Set the Method to resolve Ethereum Name Service ENS is set to Ask again in brave://settings and ensured reload the page http://brantly.eth/ opens up an interstitial page and click on proceed opens up the http://brantly.eth/ page

screenshot

image
image

  1. Ensured Method to resolve Ethereum Name Service ENS in brave://settings is set to Public DNS over HTTP server
screenshot

image

  1. Ensured open a new tab and visit brantly.eth page loads normally without any interstitial pages.

Verification passed on

Brave | 1.22.66 Chromium: 89.0.4389.90 (Official Build) (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2004 (Build 19041.867)

  1. Open Brave and visit brantly.eth and ensured opt-in interstitial page is opened (as per the issue description Do not show opt-in page for decentralized DNS support in OTR contexts #14488 (comment))
screenshot

image

  1. Go to settings, search for unstoppable, there is Method to resolve Ethereum Name Service (ENS) settings set to Ask by default
screenshot

image

  1. Ensured that open brantly.eth in normal tab is showing up This site can’t be reached page when Method to resolve Ethereum Name Service (ENS) is set to Disable in brave://settings
screenshot

image

6,7 and 8. Set the Method to resolve Ethereum Name Service (ENS) is set to Ask again in brave://settings and ensured reload the page brantly.eth opens up an interstitial page and click on proceed opens up the brantly.eth page

screenshot

image
image

  1. Ensured Method to resolve Ethereum Name Service (ENS) in brave://settings is set to Public DNS over HTTP server
screenshot

image

  1. Ensured open a new tab and visit brantly.eth page loads normally without any interstitial pages.

Encountered #14478

@zackees
Copy link

zackees commented Apr 19, 2022

Hey I just tried to visit https://resolver.cloudflare-eth.com/dns-query and I got the following error, is this a problem?

image

@brave brave deleted a comment from ana585 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment