Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC is not shown in shields on Tor tab as blocked #1453

Open
LaurenWags opened this issue Oct 8, 2018 · 1 comment
Open

WebRTC is not shown in shields on Tor tab as blocked #1453

LaurenWags opened this issue Oct 8, 2018 · 1 comment
Labels
browser-laptop-parity feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. feature/tor priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

WebRTC is being blocked in a Tor window/tab (per #1254) however, it is not being shown as blocked in shields as it was on b-l.

Steps to Reproduce

  1. Open https://diafygi.github.io/webrtc-ips/ in Tor Window
  2. Look at shields icon.

Actual result:

No badge with number of blocked items is displayed. Click on shields, verify all items are 0 regardless of whether shields are up or down:
screen shot 2018-10-08 at 5 35 34 pm
screen shot 2018-10-08 at 5 35 47 pm

Expected result:

Shields should show WebRTC blocked as they do on b-l for a Tor tab (regardless of whether shields are up or down):
screen shot 2018-10-08 at 5 34 48 pm

screen shot 2018-10-08 at 5 35 02 pm

Reproduces how often:

easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X
Brave 0.56.2 Chromium: 70.0.3538.35 (Official Build) dev (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes, both
  • Does it reproduce on browser-laptop? no, works as expected on b-l

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

If you visit https://diafygi.github.io/webrtc-ips/ in a normal tab and block all fingerprinting, shields correctly shows 1 Fingerprinting method blocked.

@LaurenWags LaurenWags added feature/shields The overall Shields feature in Brave. feature/tor browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. QA/Yes labels Oct 8, 2018
@LaurenWags LaurenWags added this to the 1.0 (0.56.x) milestone Oct 8, 2018
@tildelowengrimm tildelowengrimm added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 23, 2018
@tildelowengrimm tildelowengrimm modified the milestones: 1.0, 1.x Backlog Oct 23, 2018
@tildelowengrimm tildelowengrimm removed the feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. label Oct 23, 2018
@tildelowengrimm tildelowengrimm added design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields priority/P4 Planned work. We expect to get to it "soon". and removed feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 31, 2018
@tildelowengrimm
Copy link
Contributor

I think that the resolution here should be that the WebRTC blocks on Tor modes in particular should be exposed to shields so that we can put it in the UI.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. feature/tor priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants