Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BAP notice frequency to daily #14570

Closed
Miyayes opened this issue Mar 8, 2021 · 2 comments · Fixed by brave/brave-core#8177
Closed

Change BAP notice frequency to daily #14570

Miyayes opened this issue Mar 8, 2021 · 2 comments · Fixed by brave/brave-core#8177
Assignees
@zenparsing
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.21.x - Release #3

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 8, 2021

Description

BAP notices currently show once every 3 days until March 13, 2021. However, given the closeness to March 13th, it would be good to increase the frequency for users.

Solution

Increase frequency to daily.
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 8, 2021
@zenparsing zenparsing mentioned this issue Mar 8, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.23.x - Nightly milestone Mar 9, 2021
@brave-builds brave-builds mentioned this issue Mar 9, 2021
Merged
7 tasks
@bsclifton bsclifton mentioned this issue Mar 9, 2021
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2021 •
edited by btlechowski
Loading

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2009 (Build 19042.844)
Case 1 - non-Japan region
  1. Have region set to something other than Japan (I used Canada)
  2. Install above build
  3. Enable Rewards, do not claim UGP grant
  4. Navigate to NTP --> Confirm no BAP alert shown on NTP
  5. Close NTP
  6. Close/relaunch
  7. Open NTP --> Confirm no BAP alert shown on NTP
  8. Claim UGP grant, wait for balance to update
  9. Open NTP --> Confirm no BAP alert shown on NTP
  10. Close NTPs
  11. Close browser
  12. Advance clock by 1 day
  13. Relaunch browser
  14. Open NTP --> Confirm no BAP alert shown on NTP
  15. Close NTPs
  16. Close browser
  17. Set clock to March 13th, confirm no BAP alert shown and BAT balance is not 0 (should be amount of UGP grant)
Example 1 Example 1
image image
Case 2 - Japan region
  1. Have region set to Japan
  2. Install above build, navigate to Dev Options, enable Staging Env for Rewards and relaunch as prompted
  3. After relaunch, skip onboarding prompt, tap on Rewards logo, enable Rewards, do not claim UGP grant
  4. Navigate to NTP --> Confirm no BAP alert shown on NTP
  5. Close NTP
  6. Close/relaunch
  7. Open NTP --> Confirm no BAP alert shown on NTP
  8. Claim UGP grant, wait for balance to update (known issue that you need to close/open panel several times to get balance to show)
  9. Close/relaunch browser --> Confirm BAP alert shown
  10. Tap "OK" button --> BAP alert closed
  11. Open another NTP --> no BAP alert shown
  12. Close browser
  13. Advance clock by 1 day
  14. Relaunch browser
  15. Open NTP --> BAP alert shown on NTP
  16. Tap OK button on alert --> BAP alert closed
  17. Open NTP --> no BAP alert shown
  18. Close NTPs
  19. Close browser
  20. Check each day until March 13th to confirm BAP alert shown on NTP
  21. On March 13th, confirm no BAP alert shown and BAP balance is 0 in UI
Japan BAP Alert (English) State on March 13th
image image
Japan BAP Alert State on March 13th
japa1 japa2




Verified passed with

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	macOS Version 10.15.7 (Build 19H524)
Scenario 1: Non JP region
  1. Have region set to something other than Japan (I used US)
  2. Install above build
  3. Enable Rewards, do not claim UGP grant
  4. Navigate to NTP --> Confirm no BAP alert shown on NTP
  5. Close NTP
  6. Close/relaunch
  7. Open NTP --> Confirm no BAP alert shown on NTP
  8. Claim UGP grant, wait for balance to update
  9. Open NTP --> Confirm no BAP alert shown on NTP
  10. Close NTPs
  11. Close browser
  12. Advance clock by 1 day
  13. Relaunch browser
  14. Open NTP --> Confirm no BAP alert shown on NTP
  15. Close NTPs
  16. Close browser
  17. Set clock to March 13th, confirm no BAP alert shown and BAT balance is not 0 (should be amount of UGP grant)
non-JP
Scenario 2: JP Region
  1. Have region set to Japan
  2. Install above build
  3. Enable Rewards, do not claim UGP grant
  4. Navigate to NTP --> Confirm no BAP alert shown on NTP
  5. Close NTP
  6. Close/relaunch
  7. Open NTP --> Confirm no BAP alert shown on NTP
  8. Claim UGP grant, wait for balance to update
  9. Open NTP --> Confirm BAP alert shown on NTP
  10. Do not interact with alert, open another NTP --> BAP alert still shown
  11. Close NTPs
  12. Close/relaunch browser
  13. Open NTP --> Confirm BAP alert shown on NTP
  14. Click "x" button --> BAP alert closed
  15. Open another NTP --> no BAP alert shown
  16. Close NTPs
  17. Close browser
  18. Advance clock by 1 day
  19. Relaunch browser
  20. Open NTP --> BAP alert shown on NTP
  21. Click OK button on alert --> BAP alert closed
  22. Open NTP --> no BAP alert shown
  23. Close NTPs
  24. Close browser
  25. Check each day until March 13th to confirm BAP alert shown on NTP
  26. On March 13th, confirm no BAP alert shown and BAP balance is 0 in UI
English text for BAP alert 0 BAP balance on March 13
English JP-Eng-Mar13
Japanese text for BAP alert 0 BAP balance on March 13
Japanese JP-Japanese-Mar13

Verification passed on

Brave 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS
Scenario 1: non-Japan region

image

Scenario 2: JP Region

image

@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

  • Verified BAP notice is shown daily
Case 1 - Japan region
  1. Have region set to Japan
  2. Install above build, navigate to Dev Options, enable Staging Env for Rewards and relaunch as prompted
  3. After relaunch, skip onboarding prompt, tap on Rewards logo, enable Rewards, do not claim UGP grant
  4. Navigate to NTP --> Confirm no BAP alert shown on NTP
  5. Close NTP
  6. Close/relaunch
  7. Open NTP --> Confirm no BAP alert shown on NTP
  8. Claim UGP grant, wait for balance to update (known issue that you need to close/open panel several times to get balance to show)
  9. Close/relaunch browser --> Confirm BAP alert shown
  10. Tap "OK" button --> BAP alert closed
  11. Open another NTP --> no BAP alert shown
  12. Close browser
  13. Advance clock by 1 day
  14. Relaunch browser
  15. Open NTP --> BAP alert shown on NTP
  16. Tap OK button on alert --> BAP alert closed
  17. Open NTP --> no BAP alert shown
  18. Close NTPs
  19. Close browser
  20. Check each day until March 13th to confirm BAP alert shown on NTP
  21. On March 13th, confirm no BAP alert shown and BAP balance is 0 in UI
March 11 March13
image image
Case 2 - non-Japan region
  1. Have region set to something other than Japan (I used Canada)
  2. Install above build
  3. Enable Rewards, do not claim UGP grant
  4. Navigate to NTP --> Confirm no BAP alert shown on NTP
  5. Close NTP
  6. Close/relaunch
  7. Open NTP --> Confirm no BAP alert shown on NTP
  8. Claim UGP grant, wait for balance to update
  9. Open NTP --> Confirm no BAP alert shown on NTP
  10. Close NTPs
  11. Close browser
  12. Advance clock by 1 day
  13. Relaunch browser
  14. Open NTP --> Confirm no BAP alert shown on NTP
  15. Close NTPs
  16. Close browser
  17. Set clock to March 13th, confirm no BAP alert shown and BAT balance is not 0 (should be amount of UGP grant)
March 11 March 13
image image

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

  • Verified BAP notice is shown daily
Case 1 - Japan region
  • Have region set to Japan
  • Install above build, navigate to Dev Options, enable Staging Env for Rewards and relaunch as prompted
  • After relaunch, skip onboarding prompt, tap on Rewards logo, enable Rewards, do not claim UGP grant
  • Navigate to NTP --> Confirm no BAP alert shown on NTP
  • Close NTP
  • Close/relaunch
  • Open NTP --> Confirm no BAP alert shown on NTP
  • Claim UGP grant, wait for balance to update (known issue that you need to close/open panel several times to get balance to show)
  • Close/relaunch browser --> Confirm BAP alert shown
  • Tap "OK" button --> BAP alert closed
  • Open another NTP --> no BAP alert shown
  • Close browser
  • Advance clock by 1 day
  • Relaunch browser
  • Open NTP --> BAP alert shown on NTP
  • Tap OK button on alert --> BAP alert closed
  • Open NTP --> no BAP alert shown
  • Close NTPs
  • Close browser
  • Check each day until March 13th to confirm BAP alert shown on NTP
  • On March 13th, confirm no BAP alert shown and BAP balance is 0 in UI
March 11 March 13
image image
Case 2 - non-Japan region
  • Have region set to something other than Japan (I used Canada)
  • Install above build
  • Enable Rewards, do not claim UGP grant
  • Navigate to NTP --> Confirm no BAP alert shown on NTP
  • Close NTP
  • Close/relaunch
  • Open NTP --> Confirm no BAP alert shown on NTP
  • Claim UGP grant, wait for balance to update
  • Open NTP --> Confirm no BAP alert shown on NTP
  • Close NTPs
  • Close browser
  • Advance clock by 1 day
  • Relaunch browser
  • Open NTP --> Confirm no BAP alert shown on NTP
  • Close NTPs
  • Close browser
  • Set clock to March 13th, confirm no BAP alert shown and BAT balance is not 0 (should be amount of UGP grant)
March 11 March 13
image image

@LaurenWags LaurenWags mentioned this issue Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21.x - Release #3
Development

Successfully merging a pull request may close this issue.

Change BAP deprecation alert frequency to 1 day brave/brave-core
6 participants
@kjozwiak @zenparsing @Miyayes @srirambv @LaurenWags @btlechowski